* [PATCH 2/2 V2] staging: dgnc: remove redundant null check in
@ 2016-05-27 1:43 Daeseok Youn
2016-05-27 10:19 ` Luis de Bethencourt
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2016-05-27 1:43 UTC (permalink / raw)
To: lidza.louina
Cc: markh, gregkh, driverdev-devel, devel, linux-kernel,
kernel-janitors, luisbg
the "brd" was already checked for NULL before calling dgnc_do_remap().
the dgnc_do_remap() function was called only
from the dgnc_found_board() and the DGNC_BOARD_MAGIC value
was assigned to "brd->magic" in dgcn_found_board(). So it doesn't
need to check about magic value.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
V2: Adds more comments to Change Log.
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index 22257d2..1882ef5 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
*/
static void dgnc_do_remap(struct dgnc_board *brd)
{
- if (!brd || brd->magic != DGNC_BOARD_MAGIC)
- return;
-
brd->re_map_membase = ioremap(brd->membase, 0x1000);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in
2016-05-27 1:43 [PATCH 2/2 V2] staging: dgnc: remove redundant null check in Daeseok Youn
@ 2016-05-27 10:19 ` Luis de Bethencourt
0 siblings, 0 replies; 2+ messages in thread
From: Luis de Bethencourt @ 2016-05-27 10:19 UTC (permalink / raw)
To: Daeseok Youn, lidza.louina
Cc: markh, gregkh, driverdev-devel, devel, linux-kernel,
kernel-janitors
On 27/05/16 02:43, Daeseok Youn wrote:
> the "brd" was already checked for NULL before calling dgnc_do_remap().
>
> the dgnc_do_remap() function was called only
> from the dgnc_found_board() and the DGNC_BOARD_MAGIC value
> was assigned to "brd->magic" in dgcn_found_board(). So it doesn't
> need to check about magic value.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> V2: Adds more comments to Change Log.
>
> drivers/staging/dgnc/dgnc_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index 22257d2..1882ef5 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
> */
> static void dgnc_do_remap(struct dgnc_board *brd)
> {
> - if (!brd || brd->magic != DGNC_BOARD_MAGIC)
> - return;
> -
> brd->re_map_membase = ioremap(brd->membase, 0x1000);
> }
>
>
Looks good.
Thanks for the fixes Daeseok :)
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-27 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-27 1:43 [PATCH 2/2 V2] staging: dgnc: remove redundant null check in Daeseok Youn
2016-05-27 10:19 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox