From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbcE0KUI (ORCPT ); Fri, 27 May 2016 06:20:08 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54184 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbcE0KUF (ORCPT ); Fri, 27 May 2016 06:20:05 -0400 Message-ID: <57481F4F.5010507@osg.samsung.com> Date: Fri, 27 May 2016 11:19:59 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Daeseok Youn , lidza.louina@gmail.com CC: markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in References: <20160527014310.GA303@SEL-JYOUN-D1> In-Reply-To: <20160527014310.GA303@SEL-JYOUN-D1> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/16 02:43, Daeseok Youn wrote: > the "brd" was already checked for NULL before calling dgnc_do_remap(). > > the dgnc_do_remap() function was called only > from the dgnc_found_board() and the DGNC_BOARD_MAGIC value > was assigned to "brd->magic" in dgcn_found_board(). So it doesn't > need to check about magic value. > > Signed-off-by: Daeseok Youn > --- > V2: Adds more comments to Change Log. > > drivers/staging/dgnc/dgnc_driver.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c > index 22257d2..1882ef5 100644 > --- a/drivers/staging/dgnc/dgnc_driver.c > +++ b/drivers/staging/dgnc/dgnc_driver.c > @@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd) > */ > static void dgnc_do_remap(struct dgnc_board *brd) > { > - if (!brd || brd->magic != DGNC_BOARD_MAGIC) > - return; > - > brd->re_map_membase = ioremap(brd->membase, 0x1000); > } > > Looks good. Thanks for the fixes Daeseok :) Luis