From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcE0LBa (ORCPT ); Fri, 27 May 2016 07:01:30 -0400 Received: from mail-am1on0133.outbound.protection.outlook.com ([157.56.112.133]:47392 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750828AbcE0LB3 (ORCPT ); Fri, 27 May 2016 07:01:29 -0400 Authentication-Results: lists.linaro.org; dkim=none (message not signed) header.d=none;lists.linaro.org; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH] arm64: kasan: instrument user memory access API To: Yang Shi , , References: <1464288231-11304-1-git-send-email-yang.shi@linaro.org> CC: , , , From: Andrey Ryabinin Message-ID: <57482930.6020608@virtuozzo.com> Date: Fri, 27 May 2016 14:02:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1464288231-11304-1-git-send-email-yang.shi@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: VI1PR06CA0019.eurprd06.prod.outlook.com (10.162.116.157) To AM5PR0801MB1297.eurprd08.prod.outlook.com (10.167.216.148) X-MS-Office365-Filtering-Correlation-Id: 208c729c-73ec-468f-faf9-08d3861e3f8b X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1297;2:R26y5OB1Rx6MUve7jNRZAWY8rKgbE8bsR1KwtGBB6/ACAagtWKT0kbvvUvTaHih81ncZw2v+MeuVrioDyp4sWJ+REfqgI0mWMaoceVfLzbCSBtavk3kJQnyivzP8451FeYmFHlrpZ2DBny6ZU5TGSP4ld0EnTZFy/VZAc5uwLGHuJr5m3vSNs5zpUjgiZuVt;3:rhpqRPdNyBdFPMkEj9gsafaNs8AkJkajcfubnMjm16N9v9g4ynvT1ls52OmmSvNWmkh3EFXopkuRAAtBZ1eOQdcB6nGJCGngWsPW+8rJZiXpxKmTeIUI/nlSkFPF4+0+;25:8iYPMHwo7xZHe5lP8GgLOJehyNsAS+TcBSdwzfKAQjsi/7JfzuGXOziXyP11cmXKyWcGDc40A59+GFyjU/B2XNne77ndYI4t76oWxEfTdkHNaX1rSjTqkk90bipJcoBwYuiDU8CDhtBS0IfJNyRqsa7CF5wfa/v5qFs1o1WkbUNsotbiLvHiPWeXFjY1fOUzqOVSi3cySbyAskzMB4y7a9wcm7UQJITjUeMV9kXa1Nm1C7ZhzJ9dqkryIdf9gLOWzsXl6FVlXyWlDrDIdGuE4J3JMJ+8EhwgL3k53GzXydz9wPqYuUleeLgA5X0ev/xjwQAa6Glq93bYgX7fucit0PVHQG+MOsHRR3pOKzCzgzFDLYkYXb+XdEqsqj3ZnWYfTfYc6d//QQG+w4AuKXlqBpgud3u6pDAeSPA+eCx1IvI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1297; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:AM5PR0801MB1297;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1297; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1297;4:aPbaSTLRMGJVsoMVkM6WGyDc4wJHyzjhYMbw3Q7jVA54k7YIq98E2qlpRvzAZ/5ehwL0ETT5mJ3n5vIEng66LPyAhCgSrbLumci88PffpMHgRCXMSOE24eM3e3hYDw2pSHvXVR3ZR/bh3TbYmbaEuM0+O+H1r0Y8VUIZoGPMfncT9r8sa1KA1aBhaF8bKiRU2Of9DBHF6zON5pdMps6jKN3tIQohv5HeIyGjlgQPMu6Z1bc8xfJv4Vkf17oAumjaDELHm8PC5zVbiYrTDs0cBfuKajyh6z4YlYpYSqikhQZgO0bP6YPk5Xr8jN+fSyXiWkSwKKc8tuWvKCFkHuXHFN9Waato0AsEzT+aDdbjM9fi56hl3cNkNt4bzeuDuHmYM4HgLnyZ5XEQx7c9q8Px/IQMH+Zw0x7O7hDab0knsg0= X-Forefront-PRVS: 09555FB1AD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(377454003)(24454002)(4001350100001)(2950100001)(36756003)(2201001)(86362001)(5001770100001)(230700001)(19580405001)(575784001)(19580395003)(77096005)(8676002)(23746002)(42186005)(47776003)(66066001)(5008740100001)(81166006)(65956001)(50466002)(65806001)(76176999)(54356999)(3846002)(92566002)(65816999)(64126003)(50986999)(2906002)(586003)(5004730100002)(83506001)(4326007)(117636001)(122286003)(6116002)(189998001)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB1297;H:[10.30.19.223];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0801MB1297;23:L0fB0eA56Y4pgXUd4vXg1oj0/S7zCUopAc0?= =?Windows-1252?Q?y8PgTaQhuwrXZh2TYNbKZTY0W/rlJYEy3nDR720E9D0cWW0PrN+sPReg?= =?Windows-1252?Q?2QEN8YRBL9XQPsAj5ei7msK0GQl08RBsrSVorniU/CQh4xs84nK+lRMw?= =?Windows-1252?Q?GSV9HJpN64xJMZvAfnmlf3bq2bt0VlVuNdJ9C5Q84OwSRpnNub/xUwkI?= =?Windows-1252?Q?y5upqVEbdBsp2hbV6qJCPKobECJiHpT5EgdML4ttfokg4StTrhwIoZej?= =?Windows-1252?Q?0PWZCmIuQkzO4rhZnTPN5mS3H5TtgWHgfNunvxMKCrT9Zw2ZHBAcVPT3?= =?Windows-1252?Q?KCQ5IMNHusXXm8fNhoHUDMpYHNmMGEz106LbX22d7MaYAySWKDGDiC8D?= =?Windows-1252?Q?3OCT3wovHfwhSsbzpYMQ6lOHFD0Aoc+4xlPz/xntgjf6aW5+tJpt96d6?= =?Windows-1252?Q?J6xUmSltNX/nbmaIcYvbtujJCY+7zUP1lJHxnld7TrSXQDCzJa6wZwPQ?= =?Windows-1252?Q?1nuD5U4gC5cUqWRmtgBe42vV0D8ubfhGm8s1XxJThZNBMW6ZPatg8KBz?= =?Windows-1252?Q?gZLsfiCgjJR27vo3D19j4I3lg5k2g3VJQMNe6mc3r3tskuxGGfprPpZa?= =?Windows-1252?Q?p4KA4ZndqA/imbELm+7X4dzO1GcCWWtktclMClIVIUz8P2NRT10RLaj7?= =?Windows-1252?Q?0CN1rILpR8Gd40CtsO22llFikf7tlX+B4UMpOax70xMLrqyOrh1lGhKe?= =?Windows-1252?Q?S42yQBlzjGxe2olYK49U+WqvWN57IOi4sAZiW5MRvpmaZH+cD2ZQbVFO?= =?Windows-1252?Q?enzFcsmlJ5+l7/UfZpos6Hw0c6zWP6Hd81abvzhAc09XuHU+pdR69G0O?= =?Windows-1252?Q?JrivIQZSDJU9oNwzLllpBzWuAjTj2JjSngW3N2da7MLOZ9F13y/jnWTA?= =?Windows-1252?Q?LJ2HZny02vU8F0swGwXXACQPCfOEHf0O+iIpzZ/ZBJzUKHl7Vs/wMgyg?= =?Windows-1252?Q?LnF3oNkumigADyeDohVduKOIsRIDg3KJr1o6CKp4QRBXCNHmzL17Il/X?= =?Windows-1252?Q?jmS/p6zMfzbkl2gcdGY4+2FCl6a///uPbir3h767soRsU7166pCaoLS1?= =?Windows-1252?Q?5KmnNajDJF0c6+2ssn0FHbus7hsrGdvOCmj34p5X7mEWjkDMkUVVMG+z?= =?Windows-1252?Q?MhDtsc2JjflW0OKDW8cKzWM/LMxQKTD4=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1297;5:0+9Oji/nWFTsawjmOhIevvv8W5visyGqt/+ujicc1FCCNAAT8CD+JFdgoE+AxHbHn1PoQhYF+y6GexWNORqua4MZqz2efLxPmrps6hussak9X650CNN0RH0cdiYHyi4V4RU32jyseLJs9pgfHW8bfg==;24:jVnoqa8xn/G3h0MdO4AFQXFtHNFvxTv8BPcDZRpeD9N4A+N1Tx8TfiM968uCGFNBWYtHpgyHb7+viDPk4hPKaxemgQ/0NustRCc3WWygz/o=;7:iQ+OpkZPL18dKIcBdu/WIhR84vuf/J7TDuED/BUFyRNUGiqn37u8OzzqVHrxfMSO1qNLodZEVNNEdrCJEk1ezpWjIAtL9Hh9MQbJRZl4bjOD0afLvKF3y5h7eO5F16uLBKHJ3lxfUVvB/p2kRPX0OrwLQGNKHzjSmQjTvDcKaARuJKE/5LxVLPECrKBy4Ay3;20:5pfLvP2+15QDHhuLn7rgZ9BdruG+f2EEuc/GVhzfF+kQxkL/fMas87YEU2st0kD5W/qlNYB5fzXvAVlznS+azOUip0LlOS3XeVlyQSPdO3QKf1TtraqWnPFQ3CfzvnWHk0j0tQrUzqwn6O4z4vqVbUAiZi2vrdUk/hhUMLe50VE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2016 11:01:24.9057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1297 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2016 09:43 PM, Yang Shi wrote: > The upstream commit 1771c6e1a567ea0ba2cccc0a4ffe68a1419fd8ef > ("x86/kasan: instrument user memory access API") added KASAN instrument to > x86 user memory access API, so added such instrument to ARM64 too. > > Tested by test_kasan module. > > Signed-off-by: Yang Shi > --- > arch/arm64/include/asm/uaccess.h | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) Please, cover __copy_from_user() and __copy_to_user() too. Unlike x86, your patch doesn't instrument these two.