From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086AbcE0LwD (ORCPT ); Fri, 27 May 2016 07:52:03 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54654 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605AbcE0LwB (ORCPT ); Fri, 27 May 2016 07:52:01 -0400 Message-ID: <574834DB.5050402@osg.samsung.com> Date: Fri, 27 May 2016 12:51:55 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Daeseok Youn , lidza.louina@gmail.com CC: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] staging: dgnc: remove useless variable 'intr_count' References: <20160527065258.GA2945@SEL-JYOUN-D1> In-Reply-To: <20160527065258.GA2945@SEL-JYOUN-D1> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/16 07:52, Daeseok Youn wrote: > The 'intr_count' variable was used only for increasing. > So the 'intr_count' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c | 2 -- > drivers/staging/dgnc/dgnc_driver.h | 1 - > drivers/staging/dgnc/dgnc_neo.c | 2 -- > 3 files changed, 5 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index 46c050c..dcb808f 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -760,8 +760,6 @@ static irqreturn_t cls_intr(int irq, void *voidbrd) > > spin_lock_irqsave(&brd->bd_intr_lock, flags); > > - brd->intr_count++; > - > /* > * Check the board's global interrupt offset to see if we > * we actually do have an interrupt pending for us. > diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h > index 95ec729..7ac33ed 100644 > --- a/drivers/staging/dgnc/dgnc_driver.h > +++ b/drivers/staging/dgnc/dgnc_driver.h > @@ -183,7 +183,6 @@ struct dgnc_board { > uint nasync; /* Number of ports on card */ > > uint irq; /* Interrupt request number */ > - ulong intr_count; /* Count of interrupts */ > ulong intr_modem; /* Count of interrupts */ > ulong intr_tx; /* Count of interrupts */ > ulong intr_rx; /* Count of interrupts */ > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index ba57e95..3f8bbb3 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -926,8 +926,6 @@ static irqreturn_t neo_intr(int irq, void *voidbrd) > if (!brd || brd->magic != DGNC_BOARD_MAGIC) > return IRQ_NONE; > > - brd->intr_count++; > - > /* Lock out the slow poller from running on this board. */ > spin_lock_irqsave(&brd->bd_intr_lock, flags); > > Good catch. intr_count is set and incremented but never read. Thanks, Luis