From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbcE0OG6 (ORCPT ); Fri, 27 May 2016 10:06:58 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54799 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbcE0OG4 (ORCPT ); Fri, 27 May 2016 10:06:56 -0400 Subject: Re: [RFC PATCH] usb: typec: Various API updates and fixes To: Heikki Krogerus References: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com> <20160525183507.GA23019@roeck-us.net> <20160527075536.GC22411@kuha.fi.intel.com> Cc: Greg KH , Mathias Nyman , Felipe Balbi , Oliver Neukum , Rajaram R , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Guenter Roeck Message-ID: <57485471.3020505@roeck-us.net> Date: Fri, 27 May 2016 07:06:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160527075536.GC22411@kuha.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/2016 12:55 AM, Heikki Krogerus wrote: > Hi, > [ ... ] >> --- >> This patch applies on top of '[RFC PATCHv2] usb: USB Type-C Connector Class' >> from Heikki Krogerus. It provided the changes I made to get the code >> operational. >> >> drivers/usb/type-c/typec.c | 134 ++++++++++++++++++++++++++++++++++++--------- >> include/linux/usb/typec.h | 26 ++++++--- >> 2 files changed, 125 insertions(+), 35 deletions(-) > > Thanks Guenter. After a quick glance looks good to me. > My pleasure. > I think I'll create a development branch to my github tree for this > class and add this on top of the original v2 patch as is. Just to have > some history for as long we develop this thing. Though I'm not sure > how useful it is in this case. I think we need to put this together > fast. I'm thinking we need to target v4.8 with this. > Yes, agreed. > I'll merge this into any case to v3, and I'll send on Monday. > Sounds good. Couple of additional comments. I don't really know what to do with the 'desc' field in struct typec_mode for modes received from the partner. I wonder if it makes sense to display it for partner modes. Also, there is currently no attribute to show the partner identity (data received from the Discover Identity command). Would it make sense to add an 'identity' attribute to the partner device (plus an associated API function to set it) ? Thanks, Guenter