From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932978AbcE0OUw (ORCPT ); Fri, 27 May 2016 10:20:52 -0400 Received: from mx6.ptsecurity.com ([45.58.112.36]:20552 "EHLO mx6.ptsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbcE0OUt (ORCPT ); Fri, 27 May 2016 10:20:49 -0400 Subject: Re: [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect() To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman , , References: <1463737048-25443-1-git-send-email-alpopov@ptsecurity.com> CC: Alexander Popov From: Alexander Popov Message-ID: <574857BD.9060709@ptsecurity.com> Date: Fri, 27 May 2016 17:20:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1463737048-25443-1-git-send-email-alpopov@ptsecurity.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DC1-CAS-02.ptsecurity.ru (10.0.52.115) To DC1-MBX-02.ptsecurity.ru (10.0.52.117) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Excuse me for disturbing, could I have a feedback? On 20.05.2016 12:37, Alexander Popov wrote: > stub_disconnect() calls stub_device_reset() during usb_unbind_device() when > usb device is locked. So usb_lock_device_for_reset() in stub_device_reset() > in that case polls for one second and returns -EBUSY anyway. > > Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED. > > Signed-off-by: Alexander Popov > --- > drivers/usb/usbip/usbip_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h > index 86b0847..c4b4938 100644 > --- a/drivers/usb/usbip/usbip_common.h > +++ b/drivers/usb/usbip/usbip_common.h > @@ -242,7 +242,7 @@ enum usbip_side { > #define USBIP_EH_RESET (1 << 2) > #define USBIP_EH_UNUSABLE (1 << 3) > > -#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) > +#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_BYE) > #define SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) > #define SDEV_EVENT_ERROR_TCP (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) > #define SDEV_EVENT_ERROR_SUBMIT (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) >