From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756097AbcE0QW3 (ORCPT ); Fri, 27 May 2016 12:22:29 -0400 Received: from mail-by2on0071.outbound.protection.outlook.com ([207.46.100.71]:56553 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750744AbcE0QW1 (ORCPT ); Fri, 27 May 2016 12:22:27 -0400 X-Greylist: delayed 914 seconds by postgrey-1.27 at vger.kernel.org; Fri, 27 May 2016 12:22:26 EDT Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <574870A6.40003@caviumnetworks.com> Date: Fri, 27 May 2016 09:07:02 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Leizhen (ThunderTown)" CC: Rob Herring , Catalin Marinas , Will Deacon , linux-arm-kernel , Ganapatrao Kulkarni , Robert Richter , "David Daney" , Frank Rowand , "Grant Likely" , devicetree , linux-kernel , Zefan Li , Xinwei Hu , Tianhong Ding , Hanjun Guo Subject: Re: [PATCH 2/3] of/numa: fix a memory@ dt node can only contains one memory block References: <1464230639-9852-1-git-send-email-thunder.leizhen@huawei.com> <1464230639-9852-2-git-send-email-thunder.leizhen@huawei.com> <20160526131345.GA12024@rob-hp-laptop> <5747C0BF.505@huawei.com> In-Reply-To: <5747C0BF.505@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: BLUPR07CA0029.namprd07.prod.outlook.com (10.255.223.142) To CY1PR07MB2133.namprd07.prod.outlook.com (10.164.112.11) X-MS-Office365-Filtering-Correlation-Id: 89ec6eae-f003-464b-8c74-08d38648f4ee X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;2:k30AbpgGp8zGXC1iVNqPAGOMONiNyiGKm8VU9i9z3VXCEuO+oJ83GtHwxegMTwt4ps2vEqTSzZZAG0+SBmm2mkkWOoOaPzC6Fjx+WLHIdoFAavMTvusFvF2wTk1bxbKvb7uaeNm5DA7f3dDoayItZ61K89CcsYQRqDA208DT789TAX4nZFYWShpgYP18X06C;3:dkqtn9JyZM9ul0JPkZey+xawHolo3MCOO5scFi6ffMUGLXs6lRZE5+GQjMWEP5vsvj+hAVyOdYRUNFF6nsQhgy0FzPRYYeXzEzdum9ftBs9IVb3myI69NNzRPEttXYV1;25:exr9MlE+EMofcgg65nHrlkr7gaB1O7V1/+4BELe27iagqkVzVd2wTP41zFsUYsFvx1RqhlW475dWhZ1MClg1hOb5tM8mX15QoM2P3YTjcy4Qj1jyALt9Ay902crv+WDB7kBjWsAZWgGhm6KjH1bsWpT0tsgbcQEkIAknCc4TfTEJtPmULSaxEQXUTo80eFfLabKTQgurvPelGOZt/uQx05RsW3twn/j7mEbV8P/w0GM2HAdlUfxuCa6/QQuEJyARdDjTWLb7WOCNGSJWy1Z5zdGfcGnbSEQ1NBmdOWi9WhY0w67NtDJgtx66pzbOn8x/A7XtNcJPzBIhDa8/Q2Tg+yUrH4xrF6ioheq4Ia3Yhoc7+ETZmpa3yTk2s/eMWjEppY0eAzFikaiTPuNnHgnlofjs4yrOOPQS4+EuQgE33Fk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2133; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;20:uvYT9adChi99uswlExA5XhCcazdb6pVq/Ya7k5vYFVzl4gqGWjG1PP8nUfk7lHubvgxhB3t5za/YxmwxNWpd1FODg2j37kBls3OqrPIn7U8T9+/KGCoRdSt7CxxYDNzjT097h+mGgz50VDe0bOWz19XPH5d95dyWZHWPAX/SqbHnBsQMOrDF8wN7tOhh4Bc+dLYkwZMP7uHfLhOIx4y2C0/I21B+DkSAeWBfeynATnrFkGPcDkXqfG4IVGUjN1lDXGkbGxOl3eydqT9/7prR1LS4VQ5vB1108jqe8WCQcTomsmAyOYSl7jIQhfDW3KLIYxV8fv91w9OZFkHwbvZ020LJjoC8ZxAJYlT9TPkn2/cgPGNJWbHriI2vMIQOsne6Zw0GSo+tGWn5CZKyrvaa2S6Ztqciao28Cusujz3dPeoC5WgcwGoPgewuQT/fWnY5t/wViCYc1lm6nTZgs82NYmHPFcfSXzVoASVe3rR71QmRF+tZD9grNXMP8tfSD2KY2iMF1ZHjXj/Dc8r2AkvN9TOxV5P3DXaV9649NUjkohIPC2VQLeNAEo0curLBEqv9vWXB0hjTJYjASVNlmnvkgk7Uvk5d+dYHhKmH84N0pZ4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2133;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2133; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;4:mOzr0f6YvPHCtBTDDsYRD2oZABZXyXVG+D9URLarkKfWyxRghLgriSbndFu6A8T26wukcM+L6jzbhpakrFq95UMzkxgRQMFhHBSg5HU6glkfqeUD1v+xv7pcVdw1V15Ch8MQW2SR2rP3bXlTJilYNQ5Yyyjy9yRVN+hzVTYoSpBV4wWqBPQDNt7pNt9QaUQnsfYfh8pkjqkuebu4UGLbpFzoD3IA9TN5LJoOgffUEBSpKI8K/PcMIrfhvI782mkBofXGGTSnXtENV0om/iH8GmAX76TZcvs7msc/UziVU06AiBrIYSQFBn6Rjmpg30SFyh6UQDy+AXWG0L6vw20YP5maTR8+9ThXE+h0gw/CToEoZW4aEq1XWlLLKWw5nQTv X-Forefront-PRVS: 09555FB1AD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(377454003)(36756003)(6116002)(586003)(50466002)(4326007)(110136002)(93886004)(3846002)(19580395003)(2906002)(64126003)(92566002)(5008740100001)(230700001)(76176999)(47776003)(54356999)(50986999)(2950100001)(77096005)(81166006)(65816999)(83506001)(8676002)(4001350100001)(189998001)(66066001)(53416004)(42186005)(5004730100002)(33656002)(65956001)(65806001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2133;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR07MB2133;23:GtT0wpWkxxqQerGcXTkhavswPt89jFRO37+Ve?= =?Windows-1252?Q?Vlb7bCPMLyph9WyC+xYMhYd/oSvv/vFoZGjinpyYvU9KdvNurNo8atTY?= =?Windows-1252?Q?PvFFrzXMD9CoCAoBn4tPwrAGp6Yh9Z4PXZrBDEMAAFtc4I+maZ05R+0f?= =?Windows-1252?Q?LAMwKjGPcl8k3h5HD/1icVc+ijw3t3r2JWtAha7g5mR77Qd7L6vKzHq8?= =?Windows-1252?Q?Fld8JPfZWnc+xrcBa0W1Pznj1rs8fIT4UPrqdinx7YSFfQBYd7MUyUDF?= =?Windows-1252?Q?WqXqADPqNZ3VaqaN49STA5oGm1sIIYb7YkdAT8t5L1TaerpQ+7IosA+x?= =?Windows-1252?Q?cCdaYZVAnnDncIsYEm/YL7ehZVTn37t1d5PSjZSDqBGgXWv7b7Dqlsx2?= =?Windows-1252?Q?OoBvrNVWyKqG5KRL4rtPF20noV5r/V4O+TIiOMz/j4jEThHwohszSuFa?= =?Windows-1252?Q?2WSws8xSVx5NJgbqi0KCt+TI3HPIGJluGv4CYyvnv2QA/o1+EONfkP4f?= =?Windows-1252?Q?B6FDzyFaezEytp5+JzuCAzngEssejdYvGnP/u9Ke3b/joBOX516PRVrB?= =?Windows-1252?Q?BupxIqum4IztzJN/o4tHrY4UCVIDWyHo0u+M2n0x5fBJBKY+TON6KwHI?= =?Windows-1252?Q?aXvUXcIODcO14CTW6ZcRlchLHPePtrMFv+IiaTNO42u6p5KcmidH/IBu?= =?Windows-1252?Q?bxNbg+kebFNqbyaKRliGCcX2Ktgyu6lcCLDNuWNCqUt6cAYMhiELXZat?= =?Windows-1252?Q?fjhKjttIsWIaIetT/BNbQDAYZTw3E0SKVdPmHdalO9QjJMSwaLYwzD+g?= =?Windows-1252?Q?Gg7cZpk3V9stEPuMNypB7GeYRwWhN6Bgi0JCyN+o/MklBv6yYGDBQxbw?= =?Windows-1252?Q?4cW+cxK5vQwesbJ6oPEmfb8SidkHYpuZ7otn+EdrRVXR7OGdZj72jkC/?= =?Windows-1252?Q?30MM0sTOIVmGRj76ebYMdoApq4VlmoocM1qZashSIZA0Jqv+h46LGvAE?= =?Windows-1252?Q?Ugdi2xln4VoIwyMUims2O/Q79HjbTnKYLVXVnUQtboNhjfzyvJlwdAqh?= =?Windows-1252?Q?Qd/9ipm6ArtmLs=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;5:ComW3r2vUa3GlScEYWXYW/RDGkGMpIKrkK2XYWxcTak3W1LybtOF+BHJOgdmxKvTMWNwoTUWgU2SDjXlO9bNcgFFZxB6Xe0irV7/P6N1BH0gqLAXJPNbstX2C/oYUaJgJE5HU/3lCFA4ZiAFNW1Ujw==;24:yJVXkUw8ekInRZ2DbiBQzc47UhU8z64yTmd0tdzHPyRNswhI0TbFPE045xFnv9VKWjXhtKDo8rM8eBkd1EJj3MiW1g7hGM0POPz3xOrwVOM=;7:BblcABcolHGafajpNeHYA1FEfpd1EpJQcGVVGR2p3gQeM8zAw8U6lGVvSLYwDbRuWgGbgK9xLxutXypxu8o2WR8wfL2qk3YCvB7+UCMeHEzRySznJUKETQ9ZoHwoEzt6wzYQniTAeLq27fpzpqN3LX5aEpxTLOvSm2HwmHxJGEB7aSXicIpVjKs7ck2sXgy/ SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2016 16:07:07.0350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2016 08:36 PM, Leizhen (ThunderTown) wrote: [...] continue; > Hi, everybody: > If some "memory" node contains "numa-node-id", but some others missed. Can we simply ignored it? > I think we should break out too, and faking to only have node0. I think if some "memory" nodes contain "numa-node-id" and others do not, then you have a defective device tree. In this case I think we must continue with the existing behavior, and indicate failure. This will cause the architecture specific NUMA code to disable NUMA and force everything onto a singl pseudo-NUMA-node. I doubt there is anything to be gained by guessing which NUMA node orphaned "memory" nodes belong to. > >> else if (r) >> /* some other error */ >> break; >> >> r = of_address_to_resource(np, 0, &rsrc); >> for (i = 0; !r; i++, r = of_address_to_resource(np, i, > > But r(non-zero) is just break this loop, the original is break the outer for (;;) loop > > How about as below? > > for_each_node_by_type(np, "memory") { > ... ... > > for (i = 0; !of_address_to_resource(np, i, &rsrc); i++) { > r = numa_add_memblk(nid, rsrc.start, > rsrc.end - rsrc.start + 1); > if (r) > goto finished; > } > > if (!i) > pr_err("NUMA: bad reg property in memory node\n"); > } > > finished: > > >> &rsrc)) { >> r = numa_add_memblk(nid, rsrc.start, >> rsrc.end - rsrc.start + 1); >> } >> } >> of_node_put(np); >> >> return r; >> >> >> Perhaps with a "if (!i && r) pr_err()" for an error message at the end. >> >> Rob >> >> . >> >