From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932629AbcE2XSW (ORCPT ); Sun, 29 May 2016 19:18:22 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:54415 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932537AbcE2XSV (ORCPT ); Sun, 29 May 2016 19:18:21 -0400 X-AuditID: cbfee68f-f79d26d0000014f6-4a-574b78b9348e Message-id: <574B78BC.10700@samsung.com> Date: Mon, 30 May 2016 08:18:20 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit References: <1464331000-16230-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1464331000-16230-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWyRsSkSHdnhXe4wYQ/RhZnlx1ks7i8aw6b xZH//YwWnx78Z7a482Q9q8XxteEObB6zGy6yeNy5tofNY/OSeo+/s/azeHzeJBfAGsVlk5Ka k1mWWqRvl8CV0XdyF3vBSfaKb+tOMjUwdrJ1MXJySAiYSFz9e4wdwhaTuHBvPVCci0NIYAWj RMfHaXBFxyfPZ4JIzGKUeDZ5GyOE84BR4tSVG6wgVbwCGhJdDzYwg9gsAqoSOzdfYASx2QR0 JLZ/O84EYosKhEk8WLcXql5Q4sfkeywgtoiAn8TWHVvBVjMLdABtWDEVKMHBISwQIrHrGj/E snmMEm1fN4HdyingKfG5YRsbSA2zgJ7E/YtaIGFmAXmJzWveMoPUSwicYpc4v/84G8RBAhLf Jh8CmykhICux6QAzxGeSEgdX3GCZwCg2C8lJsxCmzkIydQEj8ypG0dSC5ILipPQiY73ixNzi 0rx0veT83E2MwEg7/e9Z/w7GuwesDzEKcDAq8fAq6HmHC7EmlhVX5h5iNAU6YiKzlGhyPjCe 80riDY3NjCxMTUyNjcwtzZTEeRdK/QwWEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwKgTIH+g bkKHZuaG6cvWramL/3XqiEvfPOlDxm9ecPi0BsaEHv3ffa87nXv/1a0nDuewT3vDcHT1AsfV s2e8ZWC7fnn9pGmvFq49NbnrXDHHMZ+Pc88HFQi+W3xXuWPBF+MlFSIar8K1zeboTit06fjU /MV4J89dT6PFRb9/lmeFnNoq+eLxa7EPSizFGYmGWsxFxYkAWeso1K8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQd2dFd7hBu/atCzOLjvIZnF51xw2 iyP/+xktPj34z2xx58l6Vovja8Md2DxmN1xk8bhzbQ+bx+Yl9R5/Z+1n8fi8SS6ANaqB0SYj NTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6AAlhbLEnFKg UEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY0bfyV3sBSfZK76tO8nUwNjJ1sXIySEh YCJxfPJ8JghbTOLCvfVAcS4OIYFZjBLPJm9jhHAeMEqcunKDFaSKV0BDouvBBmYQm0VAVWLn 5guMIDabgI7E9m/HwSaJCoRJPFi3F6peUOLH5HssILaIgJ/E1h1bwTYwC3QAbVgxFSjBwSEs ECKx6xo/xLJ5jBJtXzexgzRwCnhKfG7YxgZSwyygJ3H/ohZImFlAXmLzmrfMExiBzkRYMQuh ahaSqgWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgqP5mdQOxoO73A8xCnAwKvHw Fmh6hwuxJpYVV+YeYpTgYFYS4V1TDhTiTUmsrEotyo8vKs1JLT7EaAoMg4nMUqLJ+cBEk1cS b2hsYmZkaWRuaGFkbK4kzvv4/7owIYH0xJLU7NTUgtQimD4mDk6pBsZWjWeVfz6sCn4ZO+HL A5+/Qfxq4p5eS+9YH91oyHnQ6/4+lf/Kn7j/7V+/LvreC0eWa/tdmbyn1uYyik3qyRJ+UWmm IWBW7H3l/vrK6m8G61+zlcw79sxCqFGXaf2UEg0pcddjm073P9Iz+R99YU+94YSH2w/ohF71 Z/XRTZjabvU1xPVzbbcSS3FGoqEWc1FxIgC7RKUa/AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Applied on my repository. Thanks! Best Regards, Jaehoon Chung On 05/27/2016 03:36 PM, Shawn Lin wrote: > dw_mci_get_cd have already dealt with these for > both of internal card-detect and gpio card-detect. > > Signed-off-by: Shawn Lin > > --- > > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 829a6ee..cb30e91 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->max_seg_size = mmc->max_req_size; > } > > - if (dw_mci_get_cd(mmc)) > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > - else > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + dw_mci_get_cd(mmc); > > ret = mmc_add_host(mmc); > if (ret) >