From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbcE3DTS (ORCPT ); Sun, 29 May 2016 23:19:18 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:1221 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbcE3DTQ (ORCPT ); Sun, 29 May 2016 23:19:16 -0400 Subject: Re: [path v2 0/7] Add DRM driver for Hisilicon Hibmc To: Xinliang Liu , Rongrong Zou References: <1464514855-108050-1-git-send-email-zourongrong@gmail.com> CC: David Airlie , Emil Velikov , , dri-devel , "Hanjun Guo" , , Linuxarm , LAKML , "Linux Kernel Mailing List" , From: Rongrong Zou Message-ID: <574BAF6A.9040208@huawei.com> Date: Mon, 30 May 2016 11:11:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.30.66] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.574BB018.00DB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e9be4484df16c34557be4c3187828f4e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xinliang 在 2016/5/30 11:01, Xinliang Liu 写道: > Hi Rongrong, > > It seems that you haven't run the checkpatch script. > Please run this script to check your patches before you send them. Like bellow: > $ cd yourkerneldir > $ ./scripts/checkpatch.pl --strict yourpatches I run checkpatch.pl without "--strict", and i'll check again with this parameter, thanks! > > Thanks, > -xinliang > > On 29 May 2016 at 17:40, Rongrong Zou wrote: >> This patch set adds a new drm driver for Hisilicon Hibmc. Hibmc is a >> base board management controller, usually it is used on server for >> Out-of-band management purpose. In this patch set, we just support basic >> function for Hibmc display subsystem. Hibmc display subsystem is connected >> to host CPU by PCIe as blow: >> >> +----------+ +----------+ >> | | PCIe | Hibmc | >> |host CPU( |<----->| display | >> |arm64,x86)| |subsystem | >> +----------+ +----------+ >> >> Hardware Detail for Hibmc display subsystem >> ----------- >> >> The display subsystem of Hibmc is show as bellow: >> +----+ +----+ +----+ +--------+ >> | | | | | | | | >> | FB |----->| DE |----->|VDAC|---->|external| >> | | | | | | | VGA | >> +----+ +----+ +----+ +--------+ >> >> -DE(Display Engine) is the display controller. >> -VDAC(Video Digital-to-Analog converter) converts the RGB diaital data >> stream from DE to VGA analog signals. >> >> Change History >> ------------ >> >> Changes in v2: >> -Remove self-defined macros for bit operations. >> -Remove unused register. >> -Replace those deprecated functions with new version of them. >> -use drm_connector_register_all() to register connector after >> drm_dev_register(). >> >> The patch v1 is at >> https://lists.freedesktop.org/archives/dri-devel/2016-February/101921.html >> Sorry for too late sending. >> >> >> Rongrong Zou (7): >> idrm/hisilicon/hibmc: Add hisilicon hibmc drm master driver >> drm/hisilicon/hibmc: Add plane for DE >> drm/hisilicon/hibmc: Add crtc for DE >> drm/hisilicon/hibmc: Add encoder for VDAC >> drm/hisilicon/hibmc: Add connector for VDAC >> drm/hisilicon/hibmc: Add support for frame buffer >> drm/hisilicon/hibmc: Add maintainer for Hibmc DRM >> >> MAINTAINERS | 7 + >> drivers/gpu/drm/hisilicon/Kconfig | 1 + >> drivers/gpu/drm/hisilicon/Makefile | 3 +- >> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 13 + >> drivers/gpu/drm/hisilicon/hibmc/Makefile | 4 + >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 477 ++++++++++++++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.h | 29 ++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 399 ++++++++++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 64 +++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 286 +++++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.c | 91 +++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.h | 28 ++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h | 214 ++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 174 ++++++++ >> 14 files changed, 1789 insertions(+), 1 deletion(-) >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/Kconfig >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/Makefile >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c >> >> -- >> 1.9.1 >> > > . > -- Regards, Rongrong