From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbcE3H6K (ORCPT ); Mon, 30 May 2016 03:58:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:17557 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbcE3H6I (ORCPT ); Mon, 30 May 2016 03:58:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-de-574bf28b7797 Subject: Re: [PATCH] ARM: dts: exynos: Remove unneded always-on for regulators on Peach boards To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Cc: devicetree@vger.kernel.org, Kukjin Kim , Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <574BF28A.5000202@samsung.com> Date: Mon, 30 May 2016 09:58:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Zd3uT97hBsvuq1jMP3KO1aL/zUJW i3OvVjJavHm7hsni9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWRyaupfRYun1i0wWrXuPsDvw eKyZt4bR4/K1i8wel/t6mTxWLv/C5rFpVSebx+Yl9R5b+u+ye/RtWcXo8XmTXABnFJdNSmpO Zllqkb5dAlfG1YNeBQu5K3o33WVtYPzH0cXIySEhYCJx+ehpdghbTOLCvfVsXYxcHEICSxkl Dk7ohXKeMUr8O70IqIqdQ1ggQeJDIki9iECoxL+Ltxm7GDmASlwlpt2KB6lmFjjHJLFy/klW kBo2AWOJzcuXsIHYvAJaEm0z94HtYhFQlViw9h8LiC0qECExa/sPJogaQYkfk++BxTkF3CT+ 7vvBCjKfWUBP4v5FLZAws4C8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nON9IoT c4tL89L1kvNzNzFCYubrDsalx6wOMQpwMCrx8BZoeocLsSaWFVfmHmKU4GBWEuF9+xgoxJuS WFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBsbZi383x1tp24a9 lX3d4nrEOHFRIq9W7aenU+yFGSXut2xYeWMm226XibsWqN4tUTQ1miu4YvpekQ7hx4L96/Zc UwlRu3YtnuE9V5vvBef7U/Je3tb/x3h71qEvUyqFTJa6rG7vKVHOEZ9SXnD1ZdSl7rWs6wxM wplOLDF5cWjis621G/JbOAyUWIozEg21mIuKEwHmymSBlQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2016 11:52 PM, Javier Martinez Canillas wrote: > The regulator always-on property should only be used for regulators > that either can't be disabled or the drivers for the client devices > are not enabling the regulator and so being disabled due to unused. > > There are some max77802 regulators in the Peach Pit and Pi boards > that are always-on but shouldn't since they are enabled by drivers: > > BUCK5 is max77802 inl1 supply > BUCK7 is max77802 inl{2,10} supply > BUCK9 is max77802 inl{3,4,5,7} supply > BUCK10 is mmc1 vqmmc supply > LDO9 is adc vdd supply > > This patch removes the always-on property for these regulators. > > Some regulators should remain always-on even when they are used as > input supplies, because these regulators are also used by other > components that are not described in the DT, for example: > > LDO10 is hdmi vdd_osc supply but it's also used as input supply for > the Exynos5420 temperature sensor. > > LDO8 is hdmi vdd and vdd_pll supply but it's also used as supply for > the Exynos5420 Display port. > > BUCK2 and BUCK6 are the vdd supplies for the EAGLE and KFC clusters. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 ----- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 ----- > 2 files changed, 10 deletions(-) Thanks, applied. Best regards, Krzysztof