* [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay
@ 2016-05-30 9:09 Axel Lin
2016-05-30 9:22 ` Krzysztof Kozlowski
2016-05-30 10:28 ` Laxman Dewangan
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-05-30 9:09 UTC (permalink / raw)
To: Mark Brown
Cc: Laxman Dewangan, Krzysztof Kozlowski, Mikko Perttunen,
Liam Girdwood, linux-kernel
Current code for .set_ramp_delay() rounds down the value written to
register, while the implementation of .set_voltage_time_sel() works on
original constraints (not rounded down).
Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Update commit log base on Krzysztof's comment.
drivers/regulator/max8973-regulator.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c
index 08d2f13..3958f50 100644
--- a/drivers/regulator/max8973-regulator.c
+++ b/drivers/regulator/max8973-regulator.c
@@ -271,22 +271,18 @@ static int max8973_set_ramp_delay(struct regulator_dev *rdev,
struct max8973_chip *max = rdev_get_drvdata(rdev);
unsigned int control;
int ret;
- int ret_val;
/* Set ramp delay */
- if (ramp_delay < 25000) {
+ if (ramp_delay <= 12000)
control = MAX8973_RAMP_12mV_PER_US;
- ret_val = 12000;
- } else if (ramp_delay < 50000) {
+ else if (ramp_delay <= 25000)
control = MAX8973_RAMP_25mV_PER_US;
- ret_val = 25000;
- } else if (ramp_delay < 200000) {
+ else if (ramp_delay <= 50000)
control = MAX8973_RAMP_50mV_PER_US;
- ret_val = 50000;
- } else {
+ else if (ramp_delay <= 200000)
control = MAX8973_RAMP_200mV_PER_US;
- ret_val = 200000;
- }
+ else
+ return -EINVAL;
ret = regmap_update_bits(max->regmap, MAX8973_CONTROL1,
MAX8973_RAMP_MASK, control);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay
2016-05-30 9:09 [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Axel Lin
@ 2016-05-30 9:22 ` Krzysztof Kozlowski
2016-05-30 10:28 ` Laxman Dewangan
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-05-30 9:22 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: Laxman Dewangan, Mikko Perttunen, Liam Girdwood, linux-kernel
On 05/30/2016 11:09 AM, Axel Lin wrote:
> Current code for .set_ramp_delay() rounds down the value written to
> register, while the implementation of .set_voltage_time_sel() works on
> original constraints (not rounded down).
> Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> v2: Update commit log base on Krzysztof's comment.
> drivers/regulator/max8973-regulator.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay
2016-05-30 9:09 [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Axel Lin
2016-05-30 9:22 ` Krzysztof Kozlowski
@ 2016-05-30 10:28 ` Laxman Dewangan
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2016-05-30 10:28 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: Krzysztof Kozlowski, Mikko Perttunen, Liam Girdwood, linux-kernel
On Monday 30 May 2016 02:39 PM, Axel Lin wrote:
> Current code for .set_ramp_delay() rounds down the value written to
> register, while the implementation of .set_voltage_time_sel() works on
> original constraints (not rounded down).
> Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-30 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-30 9:09 [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Axel Lin
2016-05-30 9:22 ` Krzysztof Kozlowski
2016-05-30 10:28 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox