From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481AbcE3JWH (ORCPT ); Mon, 30 May 2016 05:22:07 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:49878 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754247AbcE3JWF (ORCPT ); Mon, 30 May 2016 05:22:05 -0400 X-AuditID: cbfec7f5-f792a6d000001302-21-574c0639374a Subject: Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay To: Axel Lin , Mark Brown References: <1464599360.12124.0.camel@ingics.com> Cc: Laxman Dewangan , Mikko Perttunen , Liam Girdwood , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <574C0638.8030406@samsung.com> Date: Mon, 30 May 2016 11:22:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1464599360.12124.0.camel@ingics.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsVy+t/xK7qWbD7hBkevKFkcmfOV2WLqwyds Fq9fGFos3beaxeLblQ4mi8u75rBZPLg6jc2B3WPnrLvsHm0/yzw2repk8+htfsfm0bdlFaPH 501yAWxRXDYpqTmZZalF+nYJXBl/29cyFvxiqZj29DNbA2MvSxcjJ4eEgIlEx/VPjBC2mMSF e+vZuhi5OIQEljJKbJ16gA0kISTwjFHiyQLuLkYODmEBd4llkwxAwiICzhJdu1qhSgwltp6Z yQLSyywwi1Hi/YZbTCAJNgFjic3Ll4AV8QpoSSyZ/AdsMYuAqsSZpoXsILaoQITErO0/mCBq BCV+TL4HVsMpYCRxrqOTHWQvs4C6xJQpuSBhZgF5ic1r3jJPYARahNAxC6FqFpKqBYzMqxhF U0uTC4qT0nON9IoTc4tL89L1kvNzNzFCwvzrDsalx6wOMQpwMCrx8BZoeocLsSaWFVfmHmKU 4GBWEuG9z+ITLsSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5O qQbGYzMyWLecez0n8/MUhmtOu7Q+Kn85MPX658Z7OZ96LafeX/K56vL1I4fm67Jci3p/7nLE pMB7E7tO3FTx51+fevqTomFZl98s9odXXkqa73Zs47xjFd2zcMeW/MUlJzJ6/vl0HjuZMu92 7lc/B6HJb1mbw3xv7uDtlNQ49/n87R3Fvw/N74+6YqDEUpyRaKjFXFScCACKj37FbwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2016 11:09 AM, Axel Lin wrote: > Current code for .set_ramp_delay() rounds down the value written to > register, while the implementation of .set_voltage_time_sel() works on > original constraints (not rounded down). > Fix the logic in .set_ramp_delay and also remove unused ret_val variable. > > Signed-off-by: Axel Lin > --- > v2: Update commit log base on Krzysztof's comment. > drivers/regulator/max8973-regulator.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof