From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754675AbcE3Kku (ORCPT ); Mon, 30 May 2016 06:40:50 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:5362 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754249AbcE3Kkt (ORCPT ); Mon, 30 May 2016 06:40:49 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 30 May 2016 03:38:57 -0700 Message-ID: <574C15C8.7050008@nvidia.com> Date: Mon, 30 May 2016 15:58:24 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Axel Lin , Mark Brown CC: Krzysztof Kozlowski , Mikko Perttunen , Liam Girdwood , Subject: Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay References: <1464599360.12124.0.camel@ingics.com> In-Reply-To: <1464599360.12124.0.camel@ingics.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 30 May 2016 02:39 PM, Axel Lin wrote: > Current code for .set_ramp_delay() rounds down the value written to > register, while the implementation of .set_voltage_time_sel() works on > original constraints (not rounded down). > Fix the logic in .set_ramp_delay and also remove unused ret_val variable. > > Signed-off-by: Axel Lin > Reviewed-by: Laxman Dewangan