From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162053AbcE3XQv (ORCPT ); Mon, 30 May 2016 19:16:51 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35539 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161249AbcE3XQt (ORCPT ); Mon, 30 May 2016 19:16:49 -0400 Subject: Re: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer To: Caesar Wang , Heiko Stuebner References: <1464169802-6033-1-git-send-email-wxt@rock-chips.com> <1464169802-6033-4-git-send-email-wxt@rock-chips.com> Cc: dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, Thomas Gleixner , cf@rock-chips.com, huangtao@rock-chips.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Daniel Lezcano Message-ID: <574CC9DE.1050501@linaro.org> Date: Tue, 31 May 2016 01:16:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1464169802-6033-4-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2016 11:50 AM, Caesar Wang wrote: > From: Huang Tao > > The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ > flag and set cpumask to all cpu to save power by avoid unnecessary > wakeups and IPIs. > > Signed-off-by: Huang Tao > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Heiko Stuebner > Tested-by: Jianqun Xu > Signed-off-by: Caesar Wang > --- > > drivers/clocksource/rockchip_timer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c > index b93fed6..f3dfb1a 100644 > --- a/drivers/clocksource/rockchip_timer.c > +++ b/drivers/clocksource/rockchip_timer.c > @@ -150,12 +150,13 @@ static void __init rk_timer_init(struct device_node *np) > } > > ce->name = TIMER_NAME; > - ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; > + ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT | > + CLOCK_EVT_FEAT_DYNIRQ; > ce->set_next_event = rk_timer_set_next_event; > ce->set_state_shutdown = rk_timer_shutdown; > ce->set_state_periodic = rk_timer_set_periodic; > ce->irq = irq; > - ce->cpumask = cpumask_of(0); > + ce->cpumask = cpu_all_mask; s/cpu_all_mask/cpu_possible_mask/ > ce->rating = 250; > > ret = request_irq(irq, rk_timer_interrupt, IRQF_TIMER, TIMER_NAME, ce); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog