From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@kernel-upstream.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: shawn.lin@rock-chips.com, ulf.hansson@linaro.org, arnd@arndb.de,
a.hajda@samsung.com, akpm@linux-foundation.org,
torvalds@linux-foundation.org, k.kozlowski@samsung.com
Subject: Re: [PATCH] mmc: core: fix the wrong error control
Date: Tue, 31 May 2016 10:00:23 +0900 [thread overview]
Message-ID: <574CE227.6070109@samsung.com> (raw)
In-Reply-To: <6ad3f39a-9ff6-6992-d9d4-8bc411128219@kernel-upstream.org>
On 05/30/2016 06:45 PM, Shawn Lin wrote:
> Hi,
>
> 在 2016/5/30 15:40, Jaehoon Chung 写道:
>> After applied "remove lots of IS_ERR_VALUE abuses", it shoold be
>> misoperation. (commit 287980e49)
>> If mmc_bus_test is successful, it returned the bus-witdh bit.
>>
>> The below log is error log
>> [ 2.542260] mmc0: mmc_select_hs200 failed, error 3
>> [ 2.542275] mmc0: error 3 whilst initialising MMC card
>>
>
> The same as this patch[0]?
Yes, discard this patch. Thanks for noticing this.
Best Regards,
Jaehoon Chung
>
> [0]https://patchwork.kernel.org/patch/9139673/
>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> drivers/mmc/core/mmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index c984321..aafb73d 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card)
>> * switch to HS200 mode if bus width is set successfully.
>> */
>> err = mmc_select_bus_width(card);
>> - if (!err) {
>> + if (err > 0) {
>> val = EXT_CSD_TIMING_HS200 |
>> card->drive_strength << EXT_CSD_DRV_STR_SHIFT;
>> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
>> @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>> } else if (mmc_card_hs(card)) {
>> /* Select the desired bus width optionally */
>> err = mmc_select_bus_width(card);
>> - if (!err) {
>> + if (err > 0) {
>> err = mmc_select_hs_ddr(card);
>> if (err)
>> goto free_card;
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
prev parent reply other threads:[~2016-05-31 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 7:40 [PATCH] mmc: core: fix the wrong error control Jaehoon Chung
2016-05-30 9:45 ` Shawn Lin
2016-05-31 1:00 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574CE227.6070109@samsung.com \
--to=jh80.chung@samsung.com \
--cc=a.hajda@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@kernel-upstream.org \
--cc=shawn.lin@rock-chips.com \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox