From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162396AbcEaBAi (ORCPT ); Mon, 30 May 2016 21:00:38 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:37765 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162278AbcEaBAa (ORCPT ); Mon, 30 May 2016 21:00:30 -0400 MIME-version: 1.0 Content-type: text/plain; charset=gbk X-AuditID: cbfee68f-f79d26d0000014f6-11-574ce22ac6c1 Content-transfer-encoding: 8BIT Message-id: <574CE227.6070109@samsung.com> Date: Tue, 31 May 2016 10:00:23 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Shawn Lin , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shawn.lin@rock-chips.com, ulf.hansson@linaro.org, arnd@arndb.de, a.hajda@samsung.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, k.kozlowski@samsung.com Subject: Re: [PATCH] mmc: core: fix the wrong error control References: <1464594014-31934-1-git-send-email-jh80.chung@samsung.com> <6ad3f39a-9ff6-6992-d9d4-8bc411128219@kernel-upstream.org> In-reply-to: <6ad3f39a-9ff6-6992-d9d4-8bc411128219@kernel-upstream.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsWyRsSkQFfrkU+4wcc/2ha31p1jtZizfg2b xd9Jx9gtXr8wtLi8aw6bxZH//YwW9zYfY7K482Q9q8WjvrfsFsfXhjtwefz+NYnR48X818we d67tYfM4MeM3i8ffWftZPPq2rGL0+LxJLoA9issmJTUnsyy1SN8ugStj1Xe+go38FZ9mHGJs YDzN3cXIySEhYCIx9/puRghbTOLCvfVsXYxcHEICKxgl5v3Yww5TdK53LztEYhajxJuvX8A6 eAUEJX5MvsfSxcjBwSwgL3HkUjZImFlAVWLb1zssEPUPGCWOLDrNDFLDK6Al8XKXPkgNC1DN 952TweazCehIbP92nAnEFhUIk3iwbi8riC0ikCGx5tsnsIOYBdYzSlw9/wisQVjAWmLd38VQ l15nlDj0rAusg1PAXeLHwx3MEFf/ZJfYt0cYYpuAxLfJh8AOlRCQldh0AKpEUuLgihssExjF ZiF5ZxbCO7OQvLOAkXkVo2hqQXJBcVJ6kbFecWJucWleul5yfu4mRmCEnv73rH8H490D1ocY BTgYlXh4OSb4hAuxJpYVV+YeYjQFOmIis5Rocj4wDeSVxBsamxlZmJqYGhuZW5opifMulPoZ LCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFxyv2sNx1Pgy953v+8i+fnuk0ij3JdWp0LCly4 58puXXUoM/pmVYdn5DLnRVPXqhr2c/uc/5/4UjLs9CrhZpUUPjuBiQk5/X8fT+x6bTvBpHuh 4ORV/5u/n804abqpiFN98WpZxugHi/id2WWm2sU/2nsp+vzVx3qzNnw11AqrX3TPYHlrdZi2 EktxRqKhFnNRcSIAcxvBn8sCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xoK7WI59wgz9XVS1urTvHajFn/Ro2 i7+TjrFbvH5haHF51xw2iyP/+xkt7m0+xmRx58l6VotHfW/ZLY6vDXfg8vj9axKjx4v5r5k9 7lzbw+ZxYsZvFo+/s/azePRtWcXo8XmTXAB7VAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7yp mYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QeUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC 4HqMDNBAwhrGjFXf+Qo28ld8mnGIsYHxNHcXIyeHhICJxLnevewQtpjEhXvr2boYuTiEBGYx Srz5+oURJMErICjxY/I9li5GDg5mAXmJI5eyQcLMAqoS277eYYGof8AocWTRaWaQGl4BLYmX u/RBaliAar7vnAw2n01AR2L7t+NMILaoQJjEg3V7WUFsEYEMiTXfPoHtZRZYzyhx9fwjsAZh AWuJdX8XQx10nVHi0LMusA5OAXeJHw93ME9gBDoT4b5ZCPfNQnLfAkbmVYwSqQXJBcVJ6bmG eanlesWJucWleel6yfm5mxjBaeCZ1A7Gg7vcDzEKcDAq8fAmTPIJF2JNLCuuzD3EKMHBrCTC q30XKMSbklhZlVqUH19UmpNafIjRFOjDicxSosn5wBSVVxJvaGxiZmRpZG5oYWRsriTO+/j/ ujAhgfTEktTs1NSC1CKYPiYOTqkGRvf5MVKqe5sPqUcvWf+3Q8DvcNabG1ZnbCUXLHlgrHk0 4NttpuVufhtN4l55/rvh+Lb3kHy6XcnzyxtWKK00uSZ+zGx2CKtp6l0fN/3EFUw5p9NnLC/S bWc5v0RRKZp55w2TV5mcd+dkv4s8KVLz9155ebqxdIHpy0c2LHemRr5/UNJduu3rOiWW4oxE Qy3mouJEAPRoI6UZAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2016 06:45 PM, Shawn Lin wrote: > Hi, > > ÔÚ 2016/5/30 15:40, Jaehoon Chung дµÀ: >> After applied "remove lots of IS_ERR_VALUE abuses", it shoold be >> misoperation. (commit 287980e49) >> If mmc_bus_test is successful, it returned the bus-witdh bit. >> >> The below log is error log >> [ 2.542260] mmc0: mmc_select_hs200 failed, error 3 >> [ 2.542275] mmc0: error 3 whilst initialising MMC card >> > > The same as this patch[0]? Yes, discard this patch. Thanks for noticing this. Best Regards, Jaehoon Chung > > [0]https://patchwork.kernel.org/patch/9139673/ > >> Signed-off-by: Jaehoon Chung >> --- >> drivers/mmc/core/mmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >> index c984321..aafb73d 100644 >> --- a/drivers/mmc/core/mmc.c >> +++ b/drivers/mmc/core/mmc.c >> @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card) >> * switch to HS200 mode if bus width is set successfully. >> */ >> err = mmc_select_bus_width(card); >> - if (!err) { >> + if (err > 0) { >> val = EXT_CSD_TIMING_HS200 | >> card->drive_strength << EXT_CSD_DRV_STR_SHIFT; >> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, >> @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, >> } else if (mmc_card_hs(card)) { >> /* Select the desired bus width optionally */ >> err = mmc_select_bus_width(card); >> - if (!err) { >> + if (err > 0) { >> err = mmc_select_hs_ddr(card); >> if (err) >> goto free_card; >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >