From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756560AbcEaIpU (ORCPT ); Tue, 31 May 2016 04:45:20 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:57152 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755946AbcEaIpQ (ORCPT ); Tue, 31 May 2016 04:45:16 -0400 X-AuditID: cbfee68f-f79d26d0000014f6-0f-574d4f194339 From: Jaewon Kim Subject: Re: Re: [RESEND][PATCH] drivers: of: of_reserved_mem: fixup the CMA alignment not to affect dma-coherent To: robh+dt@kernel.org, m.szyprowski@samsung.com Cc: r64343@freescale.com, grant.likely@linaro.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jaewon31.kim@gmail.com Message-id: <574D4F1B.4000702@samsung.com> Date: Tue, 31 May 2016 17:45:15 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsVy+t8zXV1Jf99wg7MLrCwO/NnBaNG9eSaj xeVdc9gs7q35z2qx9shddos3pw8zWbTuPcLuwO7x73A/k8fOWXfZPTat6mTz2PRpErvHnWt7 2Dz6tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4+iq8oJJ3BUN34UaGDs4uxg5OCQETCSu7nDo YuQEMsUkLtxbz9bFyMUhJLCSUeL6jwmMEAkTic8P/kElljJKdK79C5YQEnjIKLHtkzKIzSag LfF+wSRWEFtYoFhizrVWZhBbRMBAYl3DWSYQm1mgVuLIhXNgvbwCWhIvH/WDxVkEVCXuv3oD 1isqECGxet01ZogaQYkfk++xgBzKLKAuMWVKLsQYeYnNa94yg9wjIXCMXWJXN8RMFgEBiW+T D7FAPCYrsekAM8T9khIHV9xgmcAoMgvJ1FkIU2chmbqAkXkVo2hqQXJBcVJ6kbFecWJucWle ul5yfu4mRkhE9e9gvHvA+hCjAAejEg8vxwSfcCHWxLLiytxDjKZAR0xklhJNzgfGbV5JvKGx mZGFqYmpsZG5pZmSOO9CqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhilDFp8rnTJMy4+ OSPhrntLj9GWlQ1JYtcEov8eLbS+wpY4i6O956yvb8ecoqar/Lbqh+I+Jn2TnjjRlXFppbhg V/uvmD/2wpkZmZ0MPaZtspo5541SlZjKzR7MkV5Wk+izbTKb18WDKfstEoPftuVsnjI/J1DR OOHG3esREiVd+17WzZgQrsRSnJFoqMVcVJwIALcNwp+jAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t9jAV1Jf99wgx8bzCwO/NnBaNG9eSaj xeVdc9gs7q35z2qx9shddos3pw8zWbTuPcLuwO7x73A/k8fOWXfZPTat6mTz2PRpErvHnWt7 2Dz6tqxi9Pi8SS6APaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfV VsnFJ0DXLTMH6CIlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bRVeUF k7grGr4LNTB2cHYxcnJICJhIfH7wjw3CFpO4cG89kM3FISSwlFGic+1fRpCEkMBDRoltn5RB bDYBbYn3CyaxgtjCAsUSc661MoPYIgIGEusazjKB2MwCtRJHLpwD6+UV0JJ4+agfLM4ioCpx /9UbsF5RgQiJ1euuMUPUCEr8mHyPpYuRA6hXXWLKlFyIMfISm9e8ZZ7AyDcLSdUshKpZSKoW MDKvYpRILUguKE5KzzXKSy3XK07MLS7NS9dLzs/dxAiO22fSOxgP73I/xCjAwajEw+tw0Cdc iDWxrLgy9xCjBAezkghvvZdvuBBvSmJlVWpRfnxRaU5q8SFGU6DTJzJLiSbnA1NKXkm8obGJ mZGlkZmxibmxsZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUaGB02Pn4m9YB346yZlqGTTpna tcz4FRS61KDayK6k9vLXrpobYrtiYvQuqLxi41gwzzmzxUdqwbKeGU92vzgzecdF8zXxLdUP ky9MzDhZKqn6nO1axYPPTQ4r+dLvfLQx5d1WYfxhF4PqAbZDh4WfuTQypKW+OVv27puA+14n xVupZ2SKnjayXldiKc5INNRiLipOBABUaPON8QIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >Hello, > > >On 2016-05-25 16:38, Rob Herring wrote: >> On Tue, May 24, 2016 at 11:29 PM, Jaewon Kim wrote: >>> From: Jaewon >>> >>> There was an alignment mismatch issue for CMA and it was fixed by >>> commit 1cc8e3458b51 ("drivers: of: of_reserved_mem: fixup the alignment with CMA setup"). >>> However the way of the commit considers not only dma-contiguous(CMA) but also >>> dma-coherent which has no that requirement. >>> >>> This patch checks more to distinguish dma-contiguous(CMA) from dma-coherent. >>> >>> Signed-off-by: Jaewon Kim >> I suppose this needs to go to stable? If so, adding the stable tag and >> kernel version would be nice so I don't have to. Hello In my opinion, this patch is not that critical. Commit 1cc8e3458b51 might move unaligned(pageblock size) dma-coherent region. And this patch will move the region back to different address which is aligned less than pageblock size. But if you think it need to stable branch, please let me know how to add the stable tag. >> >>> --- >>> drivers/of/of_reserved_mem.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >> I'm looking for an ack from Marek on this. > >Acked-by: Marek Szyprowski Thank you for your Ack > >Best regards >-- >Marek Szyprowski, PhD >Samsung R&D Institute Poland