From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028AbcEaJP3 (ORCPT ); Tue, 31 May 2016 05:15:29 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:60783 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756751AbcEaJPZ (ORCPT ); Tue, 31 May 2016 05:15:25 -0400 Subject: Re: [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes To: Peter Griffin , , , , , , , , , References: <1464192412-16386-1-git-send-email-peter.griffin@linaro.org> <1464192412-16386-18-git-send-email-peter.griffin@linaro.org> CC: , , , From: Arnaud Pouliquen X-Enigmail-Draft-Status: N1110 Message-ID: <574D5608.3080800@st.com> Date: Tue, 31 May 2016 11:14:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1464192412-16386-18-git-send-email-peter.griffin@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.201.23.162] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-31_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2016 06:06 PM, Peter Griffin wrote: > This patch adds the DT nodes for the uniperif player > IP blocks found on STiH407 family silicon. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 76 +++++++++++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index 60f95b6..7ca149b 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -755,5 +755,81 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spdif_out >; > }; > + > + sti_uni_player0: sti-uni-player@0 { > + compatible = "st,sti-uni-player"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > + assigned-clock-parents = <&clk_s_d0_quadfs 0>; This does not work properly. You need to declare parent like this: assigned-clocks = <&clk_s_d0_quadfs 0>, <&clk_s_d0_flexgen CLK_PCM_0>; assigned-clock-parents = <0>, <&clk_s_d0_quadfs 0>; > + assigned-clock-rates = <50000000>; > + reg = <0x8D80000 0x158>; > + interrupts = ; > + dmas = <&fdma0 2 0 1>; > + dai-name = "Uni Player #0 (HDMI)"; > + dma-names = "tx"; > + st,uniperiph-id = <0>; > + st,version = <5>; > + st,mode = "HDMI"; > + }; > + > + sti_uni_player1: sti-uni-player@1 { > + compatible = "st,sti-uni-player"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > + assigned-clock-parents = <&clk_s_d0_quadfs 1>; assigned-clocks = <&clk_s_d0_quadfs 1>, <&clk_s_d0_flexgen CLK_PCM_1>; assigned-clock-parents = <0>, <&clk_s_d0_quadfs 1>; > + assigned-clock-rates = <50000000>; > + reg = <0x8D81000 0x158>; > + interrupts = ; > + dmas = <&fdma0 3 0 1>; > + dai-name = "Uni Player #1 (PIO)"; > + dma-names = "tx"; > + st,uniperiph-id = <1>; > + st,version = <5>; > + st,mode = "PCM"; > + }; > + > + sti_uni_player2: sti-uni-player@2 { > + compatible = "st,sti-uni-player"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > + assigned-clock-parents = <&clk_s_d0_quadfs 2>; assigned-clocks = <&clk_s_d0_quadfs 2>, <&clk_s_d0_flexgen CLK_PCM_2>; assigned-clock-parents = <0>, <&clk_s_d0_quadfs 2>; > + assigned-clock-rates = <50000000>; > + reg = <0x8D82000 0x158>; > + interrupts = ; > + dmas = <&fdma0 4 0 1>; > + dai-name = "Uni Player #1 (DAC)"; > + dma-names = "tx"; > + st,uniperiph-id = <2>; > + st,version = <5>; > + st,mode = "PCM"; > + }; > + > + sti_uni_player3: sti-uni-player@3 { > + compatible = "st,sti-uni-player"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > + assigned-clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > + assigned-clock-parents = <&clk_s_d0_quadfs 3>; > + assigned-clock-rates = <50000000>; assigned-clocks = <&clk_s_d0_quadfs 3>, <&clk_s_d0_flexgen CLK_SPDIFF>; assigned-clock-parents = <0>, <&clk_s_d0_quadfs 3>; Regards, Arnaud > + reg = <0x8D85000 0x158>; > + interrupts = ; > + dmas = <&fdma0 7 0 1>; > + dma-names = "tx"; > + dai-name = "Uni Player #1 (PIO)"; > + st,uniperiph-id = <3>; > + st,version = <5>; > + st,mode = "SPDIF"; > + }; > }; > }; >