From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbcEaLaK (ORCPT ); Tue, 31 May 2016 07:30:10 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:7968 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbcEaLaF (ORCPT ); Tue, 31 May 2016 07:30:05 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 31 May 2016 04:28:09 -0700 Message-ID: <574D72D0.7060303@nvidia.com> Date: Tue, 31 May 2016 16:47:36 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Axel Lin , Mark Brown CC: Liam Girdwood , Subject: Re: [PATCH RFT] regulator: tps51632: Fix setting ramp delay References: <1464686760.11354.1.camel@ingics.com> In-Reply-To: <1464686760.11354.1.camel@ingics.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 31 May 2016 02:56 PM, Axel Lin wrote: > According to the datasheet: > > SLEW Register(Address = 07h) > b7 b6 b5 b4 b3 b2 b1 b0 > 48mV/us 42mV/us 36mV/us 30mV/us 24mV/us 18mV/us 12mV/us 6mV/us > > Current code does not set correct slew rate in some cases: > e.g. Assume ramp_delay is 10000, current code sets slew register to 6mV/us. > Fix the logic to set slew register. > Setting register to nearest faster ramp side, the change looks fine. Acked-by: Laxman Dewangan