From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754658AbcEaLzF (ORCPT ); Tue, 31 May 2016 07:55:05 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:54455 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753697AbcEaLyh (ORCPT ); Tue, 31 May 2016 07:54:37 -0400 X-AuditID: cbfec7f5-f792a6d000001302-35-574d7b78af88 Subject: Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting To: Peter Chen , Ulf Hansson References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <20160505224240.GA31429@rob-hp-laptop> <20160509181829.GA19687@rob-hp-laptop> <20160528033613.GA3291@shlinux2> <20160531005808.GA7913@shlinux2> Cc: Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , linux-mmc , "linux-pm@vger.kernel.org" , linux-usb@vger.kernel.org, Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown , hverkuil@xs4all.nl, tjakobi@math.uni-bielefeld.de, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Arnd Bergmann From: Krzysztof Kozlowski Message-id: <574D7B77.4000606@samsung.com> Date: Tue, 31 May 2016 13:54:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160531005808.GA7913@shlinux2> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsVy+t/xK7oV1b7hBn9221j8nXSM3WLjjPWs FlMfPmGzmPTkPbPF/CPnWC0mrpzMbNG8eD2bxanJz5gsuq5uYrN4/cLQYtPja6wWl3fNYbM4 8r+f0eJz7xFGixnn9zFZLFrWymyx9shddov/e3awW5zeXWLRtvoDq8XxteEOoh6/f01i9Ng5 6y67x+YVWh6bVnWyedy5tofNY//cNUChJfUe/46xe/RtWcXo8XmTnMepr5/ZA7ijuGxSUnMy y1KL9O0SuDK+L1zPUnCRveLckoNsDYx/WbsYOTkkBEwkHr46wgxhi0lcuLeerYuRi0NIYCmj ROfc26wQzjNGiZ4Th5hAqoQFPCROr7vPCGKLCPhINMx/zwhR9JpJ4uisL+wgDrPADjaJCU/O soFUsQkYS2xevgTM5hXQkvh36xzYPhYBVYl9z8+BTRUViJCYtf0HE0SNoMSPyfdYQGxOAV2J zifvgIZyAA3Vk7h/UQskzCwgL7F5zVvmCYwCs5B0zEKomoWkagEj8ypG0dTS5ILipPRcI73i xNzi0rx0veT83E2MkBj9uoNx6TGrQ4wCHIxKPLwR3T7hQqyJZcWVuYcYJTiYlUR4Pat8w4V4 UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXAuCFuwn6l7j1M G8+ZNTzNu/d+3uK4nC+bDF5zHikV5/5vHZN18ORs++07brYxrl8tZZ8sv0ox8oScwJq7QVLn M+bXXZta7CgcPiFo45/5V9U2V3naL/tlu/Pnrakp/5Y1XgyIY55dJTuhKt5TuGvjmyN3lF89 XchgliwdX6uW28K/uYb50ZpLMUosxRmJhlrMRcWJADDsSK7NAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2016 02:58 AM, Peter Chen wrote: > On Sat, May 28, 2016 at 11:36:13AM +0800, Peter Chen wrote: >> All, how we move on for this? >> >> 1. Using a generic driver to manage both mmc and USB (and further >> subsystem), USB and further subsystem do not use pwrseq node in dts. >> 2. USB creates the similar driver under drivers/usb for its own use. >> >> Which one do you prefer, thanks. >> > > Hi Krzysztof Kozlowski, > > I think option 1 may be better according to Rob and Ulf's comment. Hi, I like the option #1 as well. The generic driver should rely and parse existing bindings like 'reset-gpios'. Still additional property (e.g. "do-the-power-sequence") seems needed as we do not want to play with all reset-gpios in DTB. > Would you like going on your patch set? You can work on generic pwrseq > driver, I will do USB stuffs based on generic pwrseq driver? Great, that sounds good! I'll start the work. Best regards, Krzysztof