From: Mark yao <mark.yao@rock-chips.com>
To: Yakir Yang <ykk@rock-chips.com>, David Airlie <airlied@linux.ie>,
Inki Dae <inki.dae@samsung.com>, Mark Yao <yzq@rock-chips.com>,
Thierry Reding <treding@nvidia.com>,
Jingoo Han <jingoohan1@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
emil.l.velikov@gmail.com,
Douglas Anderson <dianders@chromium.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc
Date: Wed, 1 Jun 2016 11:52:04 +0800 [thread overview]
Message-ID: <574E5BE4.7050003@rock-chips.com> (raw)
In-Reply-To: <1464066164-22863-1-git-send-email-ykk@rock-chips.com>
On 2016年05月24日 13:02, Yakir Yang wrote:
> Rockchip VOP couldn't output YUV video format for eDP controller, so
> when driver detect connector support YUV video format, we need to hack
> it down to RGB888.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2: None
>
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index f29ca3d..910cceb 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -97,6 +97,24 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data)
> return 0;
> }
>
> +static enum drm_mode_status
> +rockchip_dp_mode_valid(struct analogix_dp_plat_data *plat_data,
> + struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + struct drm_display_info *di = &connector->display_info;
> +
> + if (di->color_formats & DRM_COLOR_FORMAT_YCRCB444 ||
> + di->color_formats & DRM_COLOR_FORMAT_YCRCB422) {
> + di->color_formats &= ~(DRM_COLOR_FORMAT_YCRCB422 |
> + DRM_COLOR_FORMAT_YCRCB444);
> + di->color_formats |= DRM_COLOR_FORMAT_RGB444;
> + di->bpc = 8;
> + }
> +
> + return MODE_OK;
> +}
> +
> static bool
> rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder,
> const struct drm_display_mode *mode,
> @@ -306,6 +324,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master,
> dp->plat_data.subdev_type = dp_data->chip_type;
> dp->plat_data.power_on = rockchip_dp_poweron;
> dp->plat_data.power_off = rockchip_dp_powerdown;
> + dp->plat_data.mode_valid = rockchip_dp_mode_valid;
>
> return analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data);
> }
Looks for me, So:
Acked-by: Mark Yao <mark.yao@rock-chips.com>
--
Mark Yao
next prev parent reply other threads:[~2016-06-01 3:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 5:01 [PATCH v2 0/10] Add RK3399 eDP support and fix some bugs to analogix_dp driver Yakir Yang
2016-05-24 5:02 ` [PATCH v2 01/10] drm/bridge: analogix_dp: rename RK3288_DP to ROCKCHIP_DP Yakir Yang
2016-05-24 5:02 ` [PATCH v2 02/10] drm/rockchip: analogix_dp: split the lcdc select setting into device data Yakir Yang
2016-06-01 1:57 ` Mark yao
2016-06-08 10:56 ` Yakir Yang
2016-05-24 5:02 ` [PATCH v2 03/10] drm/bridge: analogix_dp: correct the register bit define error in ANALOGIX_DP_PLL_REG_1 Yakir Yang
2016-05-24 5:02 ` [PATCH v2 04/10] drm/bridge: analogix_dp: some rockchip chips need to flip REF_CLK bit setting Yakir Yang
2016-05-24 5:02 ` [PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support Yakir Yang
2016-05-24 6:57 ` Yakir Yang
2016-05-24 10:17 ` Heiko Stuebner
2016-05-24 18:12 ` Doug Anderson
2016-05-24 18:23 ` Heiko Stuebner
2016-05-25 5:54 ` Yakir Yang
2016-05-25 5:55 ` Yakir Yang
2016-06-01 1:48 ` Mark yao
2016-05-24 5:02 ` [PATCH v2 06/10] drm/rockchip: analogix_dp: make panel detect to an optional action Yakir Yang
2016-06-01 3:53 ` Mark yao
2016-05-24 5:02 ` [PATCH v2 07/10] drm/bridge: analogix_dp: introduce connector mode_valid callback to plat driver Yakir Yang
2016-05-24 5:02 ` [PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc Yakir Yang
2016-06-01 3:52 ` Mark yao [this message]
2016-05-24 5:02 ` [PATCH v2 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode Yakir Yang
2016-06-01 3:51 ` Mark yao
2016-05-24 5:02 ` [PATCH v2 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in Yakir Yang
2016-05-26 9:34 ` [PATCH v2 0/10] Add RK3399 eDP support and fix some bugs to analogix_dp driver Yakir Yang
2016-05-26 12:48 ` Javier Martinez Canillas
2016-05-27 6:16 ` Yakir Yang
2016-05-31 20:01 ` Javier Martinez Canillas
2016-06-01 1:47 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574E5BE4.7050003@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jingoohan1@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
--cc=yzq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox