From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757249AbcFADwU (ORCPT ); Tue, 31 May 2016 23:52:20 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:57276 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756726AbcFADwT (ORCPT ); Tue, 31 May 2016 23:52:19 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: dan.carpenter@oracle.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc To: Yakir Yang , David Airlie , Inki Dae , Mark Yao , Thierry Reding , Jingoo Han , Rob Herring References: <1464066086-21967-1-git-send-email-ykk@rock-chips.com> <1464066164-22863-1-git-send-email-ykk@rock-chips.com> Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , emil.l.velikov@gmail.com, Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Dan Carpenter From: Mark yao Message-ID: <574E5BE4.7050003@rock-chips.com> Date: Wed, 1 Jun 2016 11:52:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1464066164-22863-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月24日 13:02, Yakir Yang wrote: > Rockchip VOP couldn't output YUV video format for eDP controller, so > when driver detect connector support YUV video format, we need to hack > it down to RGB888. > > Signed-off-by: Yakir Yang > --- > Changes in v2: None > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index f29ca3d..910cceb 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -97,6 +97,24 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) > return 0; > } > > +static enum drm_mode_status > +rockchip_dp_mode_valid(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + struct drm_display_info *di = &connector->display_info; > + > + if (di->color_formats & DRM_COLOR_FORMAT_YCRCB444 || > + di->color_formats & DRM_COLOR_FORMAT_YCRCB422) { > + di->color_formats &= ~(DRM_COLOR_FORMAT_YCRCB422 | > + DRM_COLOR_FORMAT_YCRCB444); > + di->color_formats |= DRM_COLOR_FORMAT_RGB444; > + di->bpc = 8; > + } > + > + return MODE_OK; > +} > + > static bool > rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > @@ -306,6 +324,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > dp->plat_data.subdev_type = dp_data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.mode_valid = rockchip_dp_mode_valid; > > return analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data); > } Looks for me, So: Acked-by: Mark Yao -- Ｍark Yao