From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964819AbcFAERV (ORCPT ); Wed, 1 Jun 2016 00:17:21 -0400 Received: from mail-bn1on0067.outbound.protection.outlook.com ([157.56.110.67]:41590 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964806AbcFAERS (ORCPT ); Wed, 1 Jun 2016 00:17:18 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART1 V5 08/13] svm: Add interrupt injection via AVIC To: Paolo Bonzini , Borislav Petkov References: <1462388992-25242-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1462388992-25242-9-git-send-email-Suravee.Suthikulpanit@amd.com> <20160510091956.GB16752@pd.tnic> <5731F518.9000205@redhat.com> CC: , , , , , , , From: Suravee Suthikulpanit Message-ID: <574E5E4E.2040200@amd.com> Date: Tue, 31 May 2016 23:02:22 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <5731F518.9000205@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN2PR17CA0015.namprd17.prod.outlook.com (10.169.188.153) To BY1PR12MB0439.namprd12.prod.outlook.com (10.162.147.140) X-MS-Office365-Filtering-Correlation-Id: 43f6d187-ed9c-45fd-50c2-08d389d188fa X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0439;2:R98a+U0DMggF87P0XtJ41BlrwCbK8Z1BCN65R6MSc1bd27P5MKqez7BQiTc0aTgrbIIYkGwtm2GrngETZ7ZfbeCCwMvxfSeECsnSHfPUGc2GQQ3fM3jQyASEa+vWyE0YLSGhyGr1K80a/EGAMWYE3HX7t/j2tezLz8CBUObycjTZrn1I1QRjCeKkPYxj2BLu;3:suL3fmSTrz0Fwz7rW+a2qj/iq42jLEbboO7bRaEMTPYkSkmgF80VYn9uWHeMA98ZRau+slnCebBZivP6DtGMOHS7OevuTqfoDjUoMKkjtk2gmlUuZhyycZkLAD6bGBEi;25:39dfce/hBkIxDqfybQxJF2ISewWc597ceEFbYEEHLrmOAzYJBYwhI6VSNc8lcN2eufC5PuKavqPAp6RAKh09B6wDkAdFrToZVjK7/qLZUNoBYrJuMChPMi6Bq1I0Lq1+00Qyo5p20R4bw5r12uIJgBrzNbeMeO6wbvihHpIqpoWaV+e02MHaMDpH5nIC1QjpowwlGZDElwiOcFIjnq6aPxmodUDJC5wWRL6AXgEJlWWf4uHnYdtWs32PkoB3DNpkGq0fVRxYvmdN60+DDlz6FdW5C9VmUjLimRhGm/083WwCewMJFALU/dGnkce16ly1dJe2VZZIaksbHmGei30nRsWGJLaq4lABO6vxlcDAsoOUhVXkWcpV6TNt4YG6mQjm91y57VBoPmBqm4QszgcOaF5N/ivTYzfNdB5FsWvjCpg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0439; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0439;20:FAos5VSuxsli8l/hL795V0BAEJyWqXLcXHR9QJNPjKb39SUunb8ljW8vYfguOdAOU5RWvT7VRLLv+HK7uYnYwFFvxJ5J20C5xrSyuEcOJkZAK+4wKTvT3QSQFoNlhvEKYGL6k4ZT1MH1OqVuRMxUq1godoIkueqReFpBLQ4S6Hyb1eSb2UxHLESoH3fmYrZoS5CmPl7EZcibeLf26dkL0GEmdoKmzcpkWacaU/5nudt6lqbbXnlKU/yxeertoDZD2tzBct/ZzZuVAGn3dZ5CYqkYxvesoGuEHe59EvjCJK4EvVro8kmLUTs9T7qSBwPbPEGncVE3Gegwy8d/RZ2j++wHBGkvYIAHL6+lSyR3jFoFkrOTWWzd2GY69WYo3n12ek+SwgzCXfb2n3Q97SfwM27wBI54rgitdSGUFnsUonvn2J2M1d6QlKAK6wRMQAdo1Q1GUyncm0dcmPf4+1tQx0ugZKjAZ8cKNy0752SBbQOxVrYrQgESZ3KD64h1oNN/;4:vCFz80qF0vk3fu2ZfEBlnXSSq4DlczPYIEcd5bNYMzXekmAY0J6ImGFrx9EDYYKRu6qqJl9rDDRfQAEl6cGLh/R9wAVtxFk59yODBxWIv2IJyjl1HiwfofglNN4ZcH665EbmTCdzj/rltF4OECmQ9fxAAm2ElDTxHwi20+tutxRtMN+z2ouywDzJiMiorQ31RoZ7BflZgK+h+zgvCqqZNhfxoS+qQOTXG+ackJjQWQhqXTEM+HMuHghsp10EQGDOOF9gldPb6dQ+sbWxthZYBiTBVo5MIhM60Bhvhj1LwxHCV/EnqDfGmL68grgV1y71amHlSq4CqhQm3UKAm4g4YAo1faOZ1DNE9va+2E/iUF0XdCkhHnWFk29Cmnjf1zycusx3BD8ko0NhT5VaOamh+9yhhI3riJwscoJbJAqM2ZHCwBlCBJyuzigtLOk8b1Nq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BY1PR12MB0439;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0439; X-Forefront-PRVS: 096029FF66 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(586003)(36756003)(50466002)(6116002)(92566002)(4326007)(3846002)(53416004)(5004730100002)(19580395003)(59896002)(33656002)(2870700001)(83506001)(42186005)(23676002)(77096005)(15975445007)(54356999)(76176999)(5001770100001)(50986999)(47776003)(189998001)(87266999)(8676002)(65956001)(2906002)(93886004)(86362001)(4001350100001)(81166006)(2950100001)(65816999)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0439;H:wsp100718wss.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM5OzIzOnBIYmdodUFtazRkdFF5bWhXVkpzWEhrejJ5?= =?utf-8?B?ZnUxRVd3b0wvUnJaMkJqZjJ1T0p3YkVBQjFwTXRoa3pBbGxKT0JLcXVmUjlo?= =?utf-8?B?d0JLTnFGR04zQXk1WjZ5eDdoQlNNWWt3YkRtV2RQS2ZiZVRiMnZ5YWh4QlE0?= =?utf-8?B?UFR3T1V0MXk1VTYrRTZUZWhIenUxaWQ0ZVdlenNza0w1aHJoaDBpOThPeFNq?= =?utf-8?B?bmhsUG56RXJ5eHRkY3ptbnViQnJCMllYZFA2a0dZdGplNjRHSDZKN1p1MnBR?= =?utf-8?B?elFSc0xxdXgrWVU3WUhSOEpGcVhyVkp5YjBjZHQzc1RaTGlad3h2ZDZqTlVR?= =?utf-8?B?N1JrQ1B3UlNpTTdtZnFNUGFrY1o3NFhaSnVkVktSNTg2cUZuaGtNUXg4bWh3?= =?utf-8?B?NzJOUnVNMzNCRVhxOWY1UmdHcjlEbjdnMkZpcWFLWms5eDJseUtoSGMyTFRH?= =?utf-8?B?YlpyZ0dPQWNkVE5KZHRzQmhzR1NYYUw3d1k5djhKQzZXQ0xyM3BvUGlVdHhL?= =?utf-8?B?K2JudGRLRUZvNDl1Q2tKSG9VRm41eEcwbURETFRYV0ZEdklReko2U3ByK090?= =?utf-8?B?T3RtaERsQkdJSUdqTW94ZEthc1BlSUhjc2xCTkNsMEVXLyszY1NXTHFOWTVI?= =?utf-8?B?YU9NL1pQa011VkxOK1Y1V2NpZmNlSEM4VXNDaENqUnd3djUzZE1WcHM3T29M?= =?utf-8?B?bXhTd0pMSGFKRkF0M1VlUWFyd1NoWHNUQXRzQzJyN1d3d0VTYUxkOWFsOStq?= =?utf-8?B?aTdFcXJiaHFOZnhBWW42SjhaM1FDM3dxTUZLT1c2TXR0L3FkWGw1RGQ1UHhK?= =?utf-8?B?Ry9wZEF3WVE1VlNrTTVobWdMd1V1T0JQMlRiekZucnJLOHFuSklhQm1TbDFE?= =?utf-8?B?ZTdkeFNWTFVPaGdINUg0MWc0aU81dUkyTFcxSVprc21oZUV5ZUZiRlVLWS9G?= =?utf-8?B?TWhpcnhiM0M4bFJIUWcrL3VJL2U3d0ZWRDdNL0FsSGVwQkJxT2NuRlZmUFgr?= =?utf-8?B?OVh3dW81Vm1wMXFmRkx0dExlaldMekdWVXR6K1lhRFI3RHVyeDlwKzRGc2VF?= =?utf-8?B?TkhGNjdxb2Q1bC9rclZBb0E5R3gyN3VPb0FpSDQrNXJOVmNkZU1SZHlRYkVv?= =?utf-8?B?aklzbk5wdUxOWExUQm50OHdYNmxBSUk2TnB1VzNhVWp6WXNha1Y5bXZFQmVx?= =?utf-8?B?aTgvcDYzRHlVWnl2Y2lkTXgxVVdSUll0VllkYkJjWmlQblFlUjBLQWYyUWds?= =?utf-8?B?aHMzUEpnRFp5ZUI0SXB3ZU9kMlNNcFpRS2FKSGtua0dkZis4VTVna1lMTDlP?= =?utf-8?B?a0VYNkFaRXBicUVFbm1GREhRaU1CYU1JWEdhUVNEZmUzNlFOQU9HMGhoN2RX?= =?utf-8?B?aDVzOVlxRjVjRTc5M0lNMmE3SmF5Tk4yeDVFVGJRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0439;5:W5mEBrMseQJn+uCHtk6pLlH78as/II1jTHCuVzXC3XoLCQUn/idEjdu8nshG1zLvnQXVan89PnhC5jfwYTuFJJCPCh8GD7hQlrotHqthOuhZhX8cj1FCmOBDMkZ2HH0CYhpDdDsrtwgBnu47KjT+Dg==;24:/+peo/MvQXsb5hbwVgxLcNjNiEclHAMMJU4gPIAFgTIYUgFFN0578eh+xq12MU+Fo6bt6ktXwtbGxc3JkbI/pLxg0xBTUv9A6JtLATBmCAQ=;7:k/k5OMuaREQrJfMXoKaAQEUp1kn3k5IvHN80DLP2MeRy3H/TIeuvBuj9BIrBB6MgfrMJTValdbAa/RdOOMm3aBtlUyUOSkusXRpX14U+3qpjJieL8GEDdy2ucPImp4mf2Mso+TZ5ZaecgeZCxEU6gZ72HDrAcnmN8yrjFGf1aVw=;20:mLtcImhp/XVe2gHHj+a0cd6RkUJUMW7wP8/HAJ1hO+TjUIpk6IH8NOx9dMXvFDN7KegVtqsWKpmaieAIQosl/DTP6arYJAs7BHNYixr8Dbt02+nIkmnG47ThMTCR+DTJYRJh7W8bd7CWxIJ7pNM3otp3rfRRVZdjRFIms6iXLVApVdX27P6qJd07VHlS1KumsbpIPgUEWd7dUVRMvL8Mq5DaAMQqSryD8HSTRoUgp3wNx4Mr/IJTk9Pmg8aTV2Do X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2016 04:02:21.0366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0439 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sorry for late response on this. On 5/10/16 09:50, Paolo Bonzini wrote: > > > On 10/05/2016 11:19, Borislav Petkov wrote: >>>> This patch introduces a new mechanism to inject interrupt using AVIC. >>>> Since VINTR is not supported when enable AVIC, we need to inject >> "... is not supported when AVIC is enabled ..." >> >> VINTR? > > The ability to request a vmexit as soon as an interrupt can be injected > (IF=GIF=1, no interrupt window, etc.). It's called the "VINTR intercept". > >> Please write those things out in the commit message for maximum >> information transfer to the reader. :) > > More important, where does the APM document that VINTR is not supported > when AVIC is enabled? It is certainly pointless and inefficient, but > I'm not sure where it says that it doesn't work. > > Paolo > Basically, from the APM vol2 here: http://developer.amd.com/wordpress/media/2012/10/24593_APM_v21.pdf On page 115, section AVIC Enable—Virtual Interrupt Control, Bit 31: "... Enabling AVIC implicitly disables the V_IRQ, V_INTR_PRIO, V_IGN_TPR, and V_INTR_VECTOR fields in the VMCB Control Word." Thanks, Suravee