From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757678AbcFAILz (ORCPT ); Wed, 1 Jun 2016 04:11:55 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:47089 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757666AbcFAIKD (ORCPT ); Wed, 1 Jun 2016 04:10:03 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: frank.wang@rock-chips.com.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1464676811-7418-1-git-send-email-frank.wang@rock-chips.com> <1464676811-7418-2-git-send-email-frank.wang@rock-chips.com> <6548390.RQDBBuPzBf@diego> Cc: dianders@chromium.org, kishon@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, kever.yang@rock-chips.com, huangtao@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com.org From: Frank Wang Message-ID: <574E9845.30501@rock-chips.com> Date: Wed, 1 Jun 2016 16:09:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <6548390.RQDBBuPzBf@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 05/31/2016 05:02 PM, Heiko Stübner wrote: > Hi Frank, > > Am Dienstag, 31. Mai 2016, 14:40:10 schrieb Frank Wang: >> Signed-off-by: Frank Wang >> --- >> .../bindings/phy/phy-rockchip-inno-usb2.txt | 48 >> ++++++++++++++++++++ 1 file changed, 48 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> >> diff --git >> a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new file >> mode 100644 >> index 0000000..4e537b2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> @@ -0,0 +1,48 @@ >> +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK >> + >> +Required properties (phy (parent) node): >> + - compatible: should contain: >> + * "rockchip,rk3366-usb2phy" >> + - #clock-cells: should be 0. >> + - clock-names: specify the 480m output clk name. >> + >> +Optional properties: >> + - vbus_host-gpio: pull gpio high/low to control the host vbus power. > > sorry for not catching that in our earlier talks, but I believe this should be > a regulator instead. See for example vcc5_host1, vcc5v_otg in rk3288-veyron- > chromebook.dtsi . > That is OK, I will correct it in the next version. > >> +Required nodes: a sub-node is required for each port the phy provides. >> + The sub-node name is used to identify host or otg port. >> + >> +Required properties (port (child) node): >> + - #phy-cells: must be 0. See ./phy-bindings.txt for details. >> + - interrupts: irq number for host/otg port. > > make that something like: > Specify an interrupt for each entry in interrupt-names. > >> + - interrupt-names: interrupt name, in line with irq number. > > make that something like: > Shall be "linestate" for the linestate interrupt. Yeah, Got it. > --- > > You might want to add the bvalid and id interrupts for the otg phys as well > already - would make handling legacy devicetree files easier. [= if they get > specified later, the driver would always need to also handle devicetrees where > they aren't specified]. > Hmmm! you mean that I can specify these properties into documentation, even if the driver have not handled (implemented) them in current? BR. Frank