From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758032AbcFAIuh (ORCPT ); Wed, 1 Jun 2016 04:50:37 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:61168 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757468AbcFAIua (ORCPT ); Wed, 1 Jun 2016 04:50:30 -0400 X-AuditID: cbfec7f4-f796c6d000001486-06-574ea1d31565 Subject: Re: [PATCH] ARM: dts: exynos: Add TMU nodes regulator supply for Peach boards To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1464731280-24588-1-git-send-email-javier@osg.samsung.com> Cc: devicetree@vger.kernel.org, Kukjin Kim , Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <574EA1D1.6020606@samsung.com> Date: Wed, 01 Jun 2016 10:50:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1464731280-24588-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e/4Zd3LC/3CDb7s4rKYf+Qcq0X/m4Ws FuderWS0ePN2DZPF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsjg0dS+jxdLrF5ksJkxfy2LR uvcIuwOvx5p5axg9Ll+7yOxxua+XyWPl8i9sHptWdbJ5bF5S77Gl/y67R9+WVYwenzfJBXBG cdmkpOZklqUW6dslcGU0P13FXDCDt2LznL+MDYxnuLoYOTkkBEwkek+/ZIewxSQu3FvP1sXI xSEksJRR4lHXUhYI5xmjxNMts1m7GDk4hAUiJPb/1wJpEBEIlfh38TYjiC0k4CbxpX8/K0g9 s8B7JomVM1uZQBJsAsYSm5cvYQPp5RXQkvjyogIkzCKgKvHjUC8riC0KNHLW9h9g5bwCghI/ Jt9jAbE5Bdwlpp1tBlvLLKAncf8i2FpmAXmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYX FCel5xrqFSfmFpfmpesl5+duYoRE0JcdjIuPWR1iFOBgVOLhVbjoGy7EmlhWXJl7iFGCg1lJ hFdwsl+4EG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhgZ LyoxXLf3PNiy731z3MLFxYGLPvUwtPiZRHSumchzY/Xhlvl3PaWLOLqCkjWNN9tIcdp9Cnqk +uyRl+Xk7avC9CxZrwtFSiZlM247WSTi/DV6f4vGy5yQiB/Xeg9ElRfr6u70k7v7YeZZRqcb DE4bhBo0LM9W8Hy4HqUsFvqz5uPFSTPTjimxFGckGmoxFxUnAgBG0pVSnAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2016 11:48 PM, Javier Martinez Canillas wrote: > The Exynos5800 Peach Pi and Exynos5420 Peach Pit Chromebooks have the > LDO10 1.8V output connected to the VDD18_TS{01,23,4} Exynos SoC pins. > > Add this regulator as the input supply of the Thermal Management Unit > channels and also remove the always-on property since all the devices > using LDO10 as input supply are now defined. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 21 ++++++++++++++++++++- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 21 ++++++++++++++++++++- > 2 files changed, 40 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index c1247402cb17..a55760b5fa82 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -425,7 +425,6 @@ > regulator-name = "vdd_ldo10"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > - regulator-always-on; > regulator-state-mem { > regulator-off-in-suspend; > }; > @@ -924,6 +923,26 @@ > assigned-clock-parents = <&clock CLK_FIN_PLL>; > }; > > +&tmu_cpu0 { > + vtmu-supply = <&ldo10_reg>; > +}; > + > +&tmu_cpu1 { > + vtmu-supply = <&ldo10_reg>; > +}; > + > +&tmu_cpu2 { > + vtmu-supply = <&ldo10_reg>; > +}; > + > +&tmu_cpu3 { > + vtmu-supply = <&ldo10_reg>; > +}; > + > +&tmu_gpu { > + vtmu-supply = <&ldo10_reg>; > +}; > + Here and for Peach Pi please put the nodes in alphabetical order. Best regards, Krzysztof