From: Ian Abbott <abbotti@mev.co.uk>
To: Ashwin Ravichandran <ashwinravichandran24@gmail.com>,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
hsweeten@visionengravers.com
Subject: Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
Date: Wed, 1 Jun 2016 10:35:57 +0100 [thread overview]
Message-ID: <574EAC7D.9070001@mev.co.uk> (raw)
In-Reply-To: <1464772775-57175-1-git-send-email-ashwinravichandran24@gmail.com>
On 01/06/16 10:19, Ashwin Ravichandran wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
> drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 3757074..9c27999 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
> data[0] != ADDIDATA_TIMER)
> return -EINVAL;
>
> - devpriv->tsk_Current = current;
> + devpriv->tsk_current = current;
>
> devpriv->timer_mode = data[0];
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index 40ff914..b2f6712 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -68,7 +68,7 @@
> struct apci3501_private {
> unsigned long amcc;
> unsigned long tcw;
> - struct task_struct *tsk_Current;
> + struct task_struct *tsk_current;
> unsigned char timer_mode;
> };
>
> @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> }
>
> /* Enable Interrupt Send a signal to from kernel to user space */
> - send_sig(SIGIO, devpriv->tsk_Current, 0);
> + send_sig(SIGIO, devpriv->tsk_current, 0);
> ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
> ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
> ADDI_TCW_CTRL_IRQ_ENA);
>
The patch looks fine (although this odd-ball Comedi driver shouldn't
really be sending signals to a user-space task!).
Is this really PATCH 2649/2649?
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-06-01 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:19 [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Ashwin Ravichandran
2016-06-01 9:35 ` Ian Abbott [this message]
2016-06-18 4:01 ` Greg KH
2016-06-20 17:22 ` Hartley Sweeten
2016-06-18 4:01 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-06-01 6:00 Ashwin
2016-06-01 6:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EAC7D.9070001@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=ashwinravichandran24@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox