From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757883AbcFAJgF (ORCPT ); Wed, 1 Jun 2016 05:36:05 -0400 Received: from smtp145.dfw.emailsrvr.com ([67.192.241.145]:33263 "EHLO smtp145.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757845AbcFAJgC (ORCPT ); Wed, 1 Jun 2016 05:36:02 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue To: Ashwin Ravichandran , gregkh@linuxfoundation.org References: <1464772775-57175-1-git-send-email-ashwinravichandran24@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, hsweeten@visionengravers.com From: Ian Abbott Message-ID: <574EAC7D.9070001@mev.co.uk> Date: Wed, 1 Jun 2016 10:35:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1464772775-57175-1-git-send-email-ashwinravichandran24@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/16 10:19, Ashwin Ravichandran wrote: > Fixed a coding style issue. > > Signed-off-by: Ashwin Ravichandran > --- > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- > drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > index 3757074..9c27999 100644 > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev, > data[0] != ADDIDATA_TIMER) > return -EINVAL; > > - devpriv->tsk_Current = current; > + devpriv->tsk_current = current; > > devpriv->timer_mode = data[0]; > > diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c > index 40ff914..b2f6712 100644 > --- a/drivers/staging/comedi/drivers/addi_apci_3501.c > +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c > @@ -68,7 +68,7 @@ > struct apci3501_private { > unsigned long amcc; > unsigned long tcw; > - struct task_struct *tsk_Current; > + struct task_struct *tsk_current; > unsigned char timer_mode; > }; > > @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d) > } > > /* Enable Interrupt Send a signal to from kernel to user space */ > - send_sig(SIGIO, devpriv->tsk_Current, 0); > + send_sig(SIGIO, devpriv->tsk_current, 0); > ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG); > ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG | > ADDI_TCW_CTRL_IRQ_ENA); > The patch looks fine (although this odd-ball Comedi driver shouldn't really be sending signals to a user-space task!). Is this really PATCH 2649/2649? Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-