From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757953AbcFAJuC (ORCPT ); Wed, 1 Jun 2016 05:50:02 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:54485 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757735AbcFAJuA (ORCPT ); Wed, 1 Jun 2016 05:50:00 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <4dbe03dee0824ab82230d511779e2a99> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: vop: do axi reset in vop initial time To: Yakir Yang , Mark Yao , Heiko Stuebner , tfiga@chromium.org References: <1464772752-9808-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , daniel.vetter@ffwll.ch, Thierry Reding , dianders@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org From: Mark yao Message-ID: <574EAFAC.6010201@rock-chips.com> Date: Wed, 1 Jun 2016 17:49:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1464772752-9808-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月01日 17:19, Yakir Yang wrote: > There is a bug in RK3399 VOP, when bootloader/kernel only enable > VOP Big or VOP Little to display, then VOP IOMMU would failed to > reset at the initial time and VOP register couldn't write rightly. > > After do the pure reset of VOP module, then things back to right. > > Signed-off-by: Yakir Yang Hi Yakir I think you get vop iommu reset failed should be IOMMU Page fault, the vop iommu access a ummap address. You should ensure all vop windows access right iommu mapping address before attach iommu. Actually, I'm working no flash display from bootloader to kernel, and prepare remove all the reset on vop initial, because it would flash the display. Thanks. > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 1c4d5b5..4150323 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1292,7 +1292,7 @@ static int vop_initial(struct vop *vop) > { > const struct vop_data *vop_data = vop->data; > const struct vop_reg_data *init_table = vop_data->init_table; > - struct reset_control *ahb_rst; > + struct reset_control *ahb_rst, *axi_rst; > int i, ret; > > vop->hclk = devm_clk_get(vop->dev, "hclk_vop"); > @@ -1331,6 +1331,19 @@ static int vop_initial(struct vop *vop) > } > > /* > + * do aclk_reset, reset all vop registers. > + */ > + axi_rst = devm_reset_control_get(vop->dev, "axi"); > + if (IS_ERR(axi_rst)) { > + dev_err(vop->dev, "failed to get axi reset\n"); > + ret = PTR_ERR(axi_rst); > + goto err_disable_aclk; > + } > + reset_control_assert(axi_rst); > + usleep_range(10, 20); > + reset_control_deassert(axi_rst); > + > + /* > * do hclk_reset, reset all vop registers. > */ > ahb_rst = devm_reset_control_get(vop->dev, "ahb"); -- Ｍark Yao