public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hekuang <hekuang@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<alexander.shishkin@linux.intel.com>, <wangnan0@huawei.com>,
	<jpoimboe@redhat.com>, <ak@linux.intel.com>, <eranian@google.com>,
	<namhyung@kernel.org>, <adrian.hunter@intel.com>,
	<sukadev@linux.vnet.ibm.com>, <masami.hiramatsu.pt@hitachi.com>,
	<tumanova@linux.vnet.ibm.com>, <kan.liang@intel.com>,
	<penberg@kernel.org>, <dsahern@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 14/14] perf callchain: Support aarch64 cross-platform
Date: Wed, 1 Jun 2016 17:54:48 +0800	[thread overview]
Message-ID: <574EB0E8.5080609@huawei.com> (raw)
In-Reply-To: <20160601084048.GI13738@krava>



在 2016/6/1 16:40, Jiri Olsa 写道:
> On Tue, May 31, 2016 at 11:19:12AM +0000, He Kuang wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
>> index 7746e09..fced833 100644
>> --- a/tools/perf/util/Build
>> +++ b/tools/perf/util/Build
>> @@ -102,6 +102,7 @@ libperf-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
>>   libperf-$(CONFIG_LOCAL_LIBUNWIND)    += unwind-libunwind-local.o
>>   libperf-$(CONFIG_LIBUNWIND)          += unwind-libunwind.o
>>   libperf-$(CONFIG_LIBUNWIND_X86)      += libunwind/x86_32.o
>> +libperf-$(CONFIG_LIBUNWIND_AARCH64)  += libunwind/arm64.o
>>   
>>   libperf-$(CONFIG_LIBBABELTRACE) += data-convert-bt.o
>>   
>> diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
>> new file mode 100644
>> index 0000000..99c0d42
>> --- /dev/null
>> +++ b/tools/perf/util/libunwind/arm64.c
>> @@ -0,0 +1,18 @@
> also please add some comments in here describing how this file works
> like that it setups defines to compile arch specific binary from the
> generic one, which is then represented by the arm64_unwind_libunwind_ops,
> which get assigned for each arm64 thread
>
> or something along those lines
>
> thanks,
> jirka
ok
>> +#define REMOTE_UNWIND_LIBUNWIND
>> +
>> +#define LIBUNWIND__ARCH_REG_ID libunwind__arm64_reg_id
>> +
>> +#include "unwind.h"
>> +#include "debug.h"
>> +#include "libunwind-aarch64.h"
>> +#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
>> +#include "../../arch/arm64/util/unwind-libunwind.c"
>> +
>> +#undef NO_LIBUNWIND_DEBUG_FRAME
>> +#ifdef NO_LIBUNWIND_DEBUG_FRAME_AARCH64
>> +#define NO_LIBUNWIND_DEBUG_FRAME
>> +#endif
>> +#include "util/unwind-libunwind-local.c"
>> +
>> +struct unwind_libunwind_ops *
>> +arm64_unwind_libunwind_ops = &_unwind_libunwind_ops;
> SNIP
>

      reply	other threads:[~2016-06-01 10:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 11:18 [PATCH v7 00/14] Add support for remote unwind He Kuang
2016-05-31 11:18 ` [PATCH v7 01/14] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-05-31 11:19 ` [PATCH v7 02/14] perf tools: Decouple thread->address_space on libunwind He Kuang
2016-05-31 11:19 ` [PATCH v7 03/14] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang
2016-06-01  8:39   ` Jiri Olsa
2016-06-01  8:39   ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 04/14] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map He Kuang
2016-06-01  8:39   ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 05/14] perf tools: Don't mix LIBUNWIND_LIBS into LIBUNWIND_LDFLAGS He Kuang
2016-05-31 11:19 ` [PATCH v7 06/14] perf tools: Separate local/remote libunwind config He Kuang
2016-06-01  8:39   ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 07/14] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang
2016-05-31 11:19 ` [PATCH v7 08/14] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang
2016-05-31 11:19 ` [PATCH v7 09/14] perf tools: Export normalize_arch() function He Kuang
2016-05-31 11:19 ` [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods He Kuang
2016-06-01  8:40   ` Jiri Olsa
2016-06-01  8:40   ` Jiri Olsa
2016-06-01 10:02     ` Hekuang
2016-05-31 11:19 ` [PATCH v7 11/14] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang
2016-05-31 11:19 ` [PATCH v7 12/14] perf tools: Introduce flag to separate local/remote unwind compilation He Kuang
2016-05-31 11:19 ` [PATCH v7 13/14] perf callchain: Support x86 target platform He Kuang
2016-06-01  8:40   ` Jiri Olsa
2016-06-01 12:47     ` Arnaldo Carvalho de Melo
2016-06-01 13:14       ` Jiri Olsa
2016-06-01  8:40   ` Jiri Olsa
2016-06-01  9:53     ` Hekuang
2016-06-01  8:41   ` Jiri Olsa
2016-05-31 11:19 ` [PATCH v7 14/14] perf callchain: Support aarch64 cross-platform He Kuang
2016-06-01  8:40   ` Jiri Olsa
2016-06-01  9:54     ` Hekuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574EB0E8.5080609@huawei.com \
    --to=hekuang@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tumanova@linux.vnet.ibm.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox