From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757977AbcFAKGu (ORCPT ); Wed, 1 Jun 2016 06:06:50 -0400 Received: from mout.web.de ([212.227.17.12]:49520 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757138AbcFAKGs (ORCPT ); Wed, 1 Jun 2016 06:06:48 -0400 Subject: Re: [PATCH] trace-cmd: Fix reporting of unknown SVM exit reasons To: Steven Rostedt References: <5741D817.3070902@web.de> <20160531112321.0c7897a4@grimm.local.home> Cc: Linux Kernel Mailing List , kvm From: Jan Kiszka Message-ID: <574EB3B0.7060304@web.de> Date: Wed, 1 Jun 2016 12:06:40 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20160531112321.0c7897a4@grimm.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:OSIWj1IBVKYmoh+8/eZDT8lem3cHWT8MzutcOzuEjh5D98JA/M3 s6HAhiBbwzQw/P2JOzWhjbH99zD5Bdpqa9WU3CI7jJ6vgf61Vn9pw/5hdSNpi6Tl0g9pI5h lqKKiJJeJ+ZfZn/Nj0zty1KkFEoCCpXRdr+YIRxQBiOXurNo09q/7FD6J36gQ07RAd+aE2J BmsDhNtmpOxiOwpOxrU7w== X-UI-Out-Filterresults: notjunk:1;V01:K0:L53rBZ6cDSE=:r6GS3wgoe0s7PDfgqN6wKT ZJ/zoWvSgzbIZjRWUqknpZVzG4droEJAK83AMweHPppuXYwVyOkz/4GTi+U9IeQ36mFGcYZUI AiB5WJZsJqVjThTXwyAH78fUgDC8lbqR/a/BwwrSan3nEnnRINRhIy0OpXWILRrkqpF+yb9u/ gzIg+WELgZ37go93uYA2fStBnkQLH4Y55nDSMAPWpev1nbRhXC+FBkatExnAkWskTx3EVQ2Xs H9OQGzu0uIkVlJ81hnbMb9/MmAFfacb/PttwmzAAxLrn8osR0xD0qHRFM5AjebYryoAIXOc8D hhQZLsQokarIN/mgGemBwkqFheu7wOZ8BWgirtamymfbRpFjEA2IhpHmEUmM9ly+Oyu01jnih br5Zqnu+vnRPq40RaY2SLd1mqORiPO7Zpte9DunIr/3g5V60KFsCH9qDWoRnamwmybrfLyytN AYuhFKtceNBBNTjeOsTE7hI6i7m3gUGRZoptnb6fVKWwvnEcdWbX2vs2kWB7H+CmtHG/LMhYq CnVKNMpVDi7L7yUrwRIWlLRzyRpaBjGYJ4RjUYd8IzKocoyPE5e8kqg/ujZ95ySnTiLe3mIZG QV1oTAnnOSIIQu8po6GeOoD3ju8tSZm4MOFr6YRuCRUF7gPUUZczoeCBzHaBJxGl0pbwScRcX CaRxxfS4yJPIvGVf33EQCG642VM7OvOf7v7IsyaSJoIR8NBjTJ4rI4XE9JHVhvWnEnchCDzwg FTtGpqqDqa5GylSm/kyUsgv3NnopaXyQdRu06zdmd3s7sxvMJA4jQHyjx5IHXwn6mCNMqkdoM GPHMfLQpK7usEQN7FkabRrvZH9XJQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-31 17:23, Steven Rostedt wrote: > On Sun, 22 May 2016 18:02:31 +0200 > Jan Kiszka wrote: > > Hi Jan, > > I finally got around to looking at your patches (not much to do on a 12 > hour layover :-p). > >> From: Jan Kiszka >> >> On AMD, exist code -1 is also a possible value, but we use it for >> terminating the list of known exit reasons. This leads to EXIT_ERR >> being reported for unkown ones. Fix this by using an NULL string >> pointer as terminal. >> >> Signed-off-by: Jan Kiszka >> --- >> plugin_kvm.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/plugin_kvm.c b/plugin_kvm.c >> index 15a6f4c..99e920f 100644 >> --- a/plugin_kvm.c >> +++ b/plugin_kvm.c >> @@ -208,12 +208,12 @@ struct str_values { >> >> static struct str_values vmx_exit_reasons[] = { >> VMX_EXIT_REASONS >> - { NULL, -1} >> + { } > > Just a preference, but I would rather this still explicitly show the > NULL. The second value is meaningless with the change below. Thus, I'm > going to nuke these two hunks and just add the last one, which should > still work for you. Fine for me. Thanks, Jan > > If not, let me know, or just tell me this weekend ;-) (I wont be > pushing this to my main server till I get back anyway) > > -- Steve > >> }; >> >> static struct str_values svm_exit_reasons[] = { >> SVM_EXIT_REASONS >> - { NULL, -1} >> + { } >> }; >> >> static struct isa_exit_reasons { >> @@ -237,7 +237,7 @@ static const char *find_exit_reason(unsigned isa, int val) >> } >> if (!strings) >> return "UNKNOWN-ISA"; >> - for (i = 0; strings[i].val >= 0; i++) >> + for (i = 0; strings[i].str; i++) >> if (strings[i].val == val) >> break; >> >