From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757826AbcFAKKv (ORCPT ); Wed, 1 Jun 2016 06:10:51 -0400 Received: from foss.arm.com ([217.140.101.70]:36644 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757651AbcFAKKt (ORCPT ); Wed, 1 Jun 2016 06:10:49 -0400 Subject: Re: [RFC PATCH 0/2] scpi: Add SCPI framework to handle vendors variants To: Neil Armstrong References: <1464255491-18503-1-git-send-email-narmstrong@baylibre.com> <57472450.4000709@arm.com> <574802AF.2080909@baylibre.com> <574BFA13.40009@baylibre.com> Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <574EB4A5.9000805@arm.com> Date: Wed, 1 Jun 2016 11:10:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <574BFA13.40009@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/05/16 09:30, Neil Armstrong wrote: > On 05/27/2016 10:17 AM, Neil Armstrong wrote: [..] > > While looking for other ARMv8 based platform, I found that the RK3368 > platform has the same SCPI implementation as Amlogic. > > They extended it with DDR, system and thermal commands. > > Look at : > https://github.com/geekboxzone/mmallow_kernel/blob/geekbox/drivers/mailbox/scpi_cmd.h > >https://github.com/geekboxzone/mmallow_kernel/blob/geekbox/drivers/mailbox/scpi_protocol.c > > So the SCPI must have a framework to allow different protocol > versions, and must allow command extension. Grouping Rockchip and > Amlogic should be done, thus needing a generic name like vendor_scpi > or with a version. > Makes sense. I understand the need to reuse and I need a bit of time to have a look at the code(both Amlogic one's you have pointed out and the Rockchip one) in detail to see what's the best way to proceed. I will have a look at this later this week and get back to you. > Sudeep, could you somehow find out which version of the protocol > AmLogic and Rockchip based their SCPI development ? > Yes I tried checking with Rockchip but didn't get a response. But my guess is that it was some preliminary unpublished version of SCPI unfortunately :( -- Regards, Sudeep