From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757138AbcFAKVN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jun 2016 06:21:13 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:9779 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751727AbcFAKVL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jun 2016 06:21:11 -0400
X-AuditID: cbfec7f4-f796c6d000001486-2e-574eb7131a6c
Subject: Re: usbip: vudc: Fix apparent cut-n-paste error
To: Dave Jones <davej@codemonkey.org.uk>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Karol Kosik <karo9@interia.eu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20160531152509.GA14338@codemonkey.org.uk>
From: Krzysztof Opasiak <k.opasiak@samsung.com>
Message-id: <574EB712.1020905@samsung.com>
Date: Wed, 01 Jun 2016 12:21:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-version: 1.0
In-reply-to: <20160531152509.GA14338@codemonkey.org.uk>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsVy+t/xa7rC2/3CDS5tULeY2vGSzaJ58Xo2
	i22fd7NaXN41h82BxWPCzwesHu0/XrB67J+7ht3j8ya5AJYoLpuU1JzMstQifbsEroxnR2ex
	FFxnq1i2bBNbA+N+1i5GDg4JAROJ5uPKXYycQKaYxIV769m6GLk4hASWMko0nH7PDJIQEnjO
	KLHhiS6ILSxgIfH930lmkCIRgVWMEhP/X2CFKDKT+PL2FNhQNgF9iXm7REHCvAJaEh+v9zKB
	2CwCqhLPrjxiA7FFBSIknsw9yQhRIyjxY/I9FhCbU8Bc4vX5f2BjmAX0JO5f1AIJMwvIS2xe
	85Z5AiP/LCQdsxCqZiGpWsDIvIpRNLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMjJDy/7GBcfMzq
	EKMAB6MSD6/CRd9wIdbEsuLK3EOMEhzMSiK8HFv8woV4UxIrq1KL8uOLSnNSiw8xSnOwKInz
	zt31PkRIID2xJDU7NbUgtQgmy8TBKdXAqBSQ386RHhyQ4/3i5tqVPOqBfx/0P2ebfZXFum9q
	9PqulFce18w0b0oJX+VktvabNsegQqj5NrvmicT1Ao5lG7iDgixFUpw6XQ7KnE17uGyfJdOZ
	2Igp5V/2ijNV7uA87fl7bbbmmyc739p+Tw0K2lPMnZXBf7zwQ1bYGjnL6X5hWd+DdqgpsRRn
	JBpqMRcVJwIAu/8LjUsCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 05/31/2016 05:25 PM, Dave Jones wrote:
> Coverity picked up that this looks like a cut-n-paste from an almost
> identical sequence below that didn't get its variable renamed.
> 
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
> 
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 8994a13819ab..7091848df6c8 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -450,7 +450,7 @@ static void vudc_shutdown(struct usbip_device *ud)
>  	if (ud->tcp_socket)
>  		kernel_sock_shutdown(ud->tcp_socket, SHUT_RDWR);
>  
> -	if (ud->tcp_tx) {
> +	if (ud->tcp_rx) {
>  		kthread_stop_put(ud->tcp_rx);
>  		ud->tcp_rx = NULL;
>  	}
> 
> 

Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics