From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbcFATKh (ORCPT ); Wed, 1 Jun 2016 15:10:37 -0400 Received: from www381.your-server.de ([78.46.137.84]:45431 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbcFATKf (ORCPT ); Wed, 1 Jun 2016 15:10:35 -0400 Subject: Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency To: Alison Schofield , jic23@kernel.org References: <20160601043541.GA9875@d830.WORKGROUP> Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Lars-Peter Clausen Message-ID: <574F3324.8020904@metafoo.de> Date: Wed, 1 Jun 2016 21:10:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160601043541.GA9875@d830.WORKGROUP> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2016 06:35 AM, Alison Schofield wrote: > Driver was checking for direct mode and trying to lock it, but > left a gap where mode could change before the desired operation. > Use iio_device_claim_direct_mode() to guarantee device stays in > direct mode. > > Refactor function to clarify look-up followed by lock sequence. > > Signed-off-by: Alison Schofield > Cc: Daniel Baluta Looks good, thanks. Acked-by: Lars-Peter Clausen