From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbcFAW17 (ORCPT ); Wed, 1 Jun 2016 18:27:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33382 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbcFAW15 (ORCPT ); Wed, 1 Jun 2016 18:27:57 -0400 Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver To: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, Shanker Donthineni , Greg Kroah-Hartman , vikrams@codeaurora.org, cov@codeaurora.org, gavidov@codeaurora.org, Rob Herring , andrew@lunn.ch, bjorn.andersson@linaro.org, Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" References: <1460570393-19838-1-git-send-email-timur@codeaurora.org> <570EC541.6080603@gmail.com> From: Timur Tabi Message-ID: <574F6168.3020802@codeaurora.org> Date: Wed, 1 Jun 2016 17:27:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <570EC541.6080603@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Florian Fainelli wrote: >> +/* Transmit the packet */ >> >+static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev) >> >+{ >> >+ struct emac_adapter *adpt = netdev_priv(netdev); >> >+ >> >+ return emac_mac_tx_buf_send(adpt, &adpt->tx_q, skb); > I would inline emac_mac_tx_buf_send()'s body here to make it much easier > to read and audit... I'm close to submitting a v5 of this patchset. The change to phylib has resulted in significant other changes. I'm sure it's still not quite right, so I ask your patience in reviewing it. However, I'm not sure inlining emac_mac_tx_buf_send() into emac_start_xmit() is good idea. That would result in moving several functions from emac-mac.c into emac.c. I'm concerned about maintaining the functional split between the two files. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation collaborative project.