From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752457AbcFBGSf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 02:18:35 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:40313 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750824AbcFBGSc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 02:18:32 -0400
X-AuditID: cbfec7f5-f792a6d000001302-1e-574fcfb47ff1
Subject: Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem
 to Exynos5410
To: Javier Martinez Canillas <javier@osg.samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org
References: <1464774351-23604-1-git-send-email-k.kozlowski@samsung.com>
 <1464774351-23604-3-git-send-email-k.kozlowski@samsung.com>
 <f7e99aad-f773-27c6-d554-ba30bc54b5f7@osg.samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
X-Enigmail-Draft-Status: N1110
Message-id: <574FCFB2.1080607@samsung.com>
Date: Thu, 02 Jun 2016 08:18:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-version: 1.0
In-reply-to: <f7e99aad-f773-27c6-d554-ba30bc54b5f7@osg.samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsVy+t/xa7pbzvuHGzy4qWuxccZ6Vov5R86x
	Wrx5u4bJ4vULQ4v+x6+ZLTY9vsZq8bHnHqvF5V1z2CxmnN/HZHHxlKvF4TftrBY/znSzWKza
	9YfRgdfj/Y1Wdo/Lfb1MHjtn3WX32LSqk81j85J6jy39QF7fllWMHp83yQVwRHHZpKTmZJal
	FunbJXBldN9/wlawlrPixom7LA2Mq9m7GDk5JARMJBa9XM8EYYtJXLi3nq2LkYtDSGApo0R/
	5yUo5xmjxK0r3xlBqoQF4iRO/PsK1iEisIhZ4uN3FxBbSGAfo0TvKQEQm1nAQmLrVogNbALG
	EpuXL2GD2CAn0ds9iQXE5hXQkuiY0wlmswioSsxv72YFsUUFIiRmbf/BBFEjKPFj8j2wGk4B
	Z4kN/xcBxTmA5utJ3L+oBbFKXmLzmrfMExgFZyHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5RnrF
	ibnFpXnpesn5uZsYIfH0dQfj0mNWhxgFOBiVeHgZdPzDhVgTy4orcw8xSnAwK4nwdp0DCvGm
	JFZWpRblxxeV5qQWH2KU5mBREueduet9iJBAemJJanZqakFqEUyWiYNTqoHRj3HXxdqW9wcW
	WXU7l4RGTtnbePDjycZsy+8vMx4Hxylb2Rd9KdzYNOnU/6+LO2e02mmYMa8y3Wz7pq54htoj
	vmmb1POW/ZuyKNFuzXennjXGzj++dxupen+2SjJWvnlu9Zzdp7i+eFxYNjvM1cqiTjf2uX6I
	RaX0hGWiqUmPsvcx7/2sdjJFiaU4I9FQi7moOBEAQ42GY6MCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
>> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
>> shared with Exynos5410 and configure the clocks on the latter.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
> 
> [snip]
> 
>>  
>> +&sss {
>> +	clocks = <&clock CLK_SSS>;
>> +	clock-names = "secss";
>> +};
>> +
> 
> [snip]
> 
>>  
>> +&watchdog {
>> +	clocks = <&clock CLK_WDT>;
>> +	clock-names = "watchdog";
>> +	samsung,syscon-phandle = <&pmu_system_controller>;
>> +};
>> +
> 
> Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
> I wonder if the clock and clock-names shouldn't be just defined in the
> shared exynos54xx.dtsi as is the case for the interrupts that are also
> the same?
> 
> The patch looks good to me though, so whatever you decide:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks for review and comments.

The 'clock' property cannot be moved - there is no clock phandle and the
clock IDs are not included in 54xx.

Best regards,
Krzysztof