From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932404AbcFBJQq (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 05:16:46 -0400
Received: from mout.web.de ([212.227.15.14]:52810 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932164AbcFBJQn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 05:16:43 -0400
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for
 Bananapi M1 Plus board
To: maxime.ripard@free-electrons.com, Julian Calaby <julian.calaby@gmail.com>
References: <20160602023623.5761-1-luoyi.ly@gmail.com>
 <CAGRGNgUiGaxoVxtq=k8NG5mCqEXS9fd-ry1vvVJfzb+R2ATMTA@mail.gmail.com>
 <20160602081638.GG4908@lukather>
Cc: luoyi.ly@gmail.com, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>, Chen-Yu Tsai <wens@csie.org>,
        devicetree <devicetree@vger.kernel.org>,
        "Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
From: Bernhard Nortmann <bernhard.nortmann@web.de>
Message-ID: <574FF94B.3020309@web.de>
Date: Thu, 2 Jun 2016 11:15:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20160602081638.GG4908@lukather>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:9hu2PoPfBssTcot1ul98g7xoX62VhcABn5lkj+5+8o+SW/nKHQb
 Z3zwnP2Gm9wLB56kjwmZfrA9W2bflc6pPBWtd1+aKoVB71RlSLtEtYQuZmrJR6NodRQOVOQ
 2EDrEIwL01ZPI0r7u7KJdKM5xuHj4KswGRYphJwKTLQTnWg4rRiLl4/S+eTBmVsnLYZUSLF
 NjkSq2O8O4lJnIlXehhfw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:5pp+zL0F22E=:f7R8iwVv5+IKdfCe55Bq6Z
 1IQA4UNGQFPXR/iuBXFGYeldmPngMCiUVDKej8PDU2H8sDeUueyDvhKeMgWb76Ca6qmmAbKGw
 PrVuZ1NctejSNtM7L64h5hsfheAjA0Jv3lcoAWDEYb1f6NFDQ5UUSyOKwJCZS0tpwdRHwtmr1
 zuRWdg3z3BYQyZ8dHrWfq8Jr3Pkx7VW27LnioCN1g50I5ALDkDzGW/NYmqcDNV30QeXJJ3hxb
 6ejIvXTx9WmPbSG4yNK6k9YmWCHegxzasvhe4z19BfZXiIJppIixBjSvH1MkIoj6nmZo11mVA
 sAHBQbNLIazy3z+AcK0DLvzs2trja8lBMqMPz5aFf9c/33PsHfbEm9LA2L2U0u8EEJVg3f0KI
 0kywiyKcAQy2t8REEpl70eyueghGHngFMrMitt16c0dg3IwQPDx/L2Zkl2p9RQ2/0v6UsGXyd
 u24+slHqBmhP0DofotUj567A9OWQlcTOI0sPlzV7EJ0C7Lz83Bi0zo8BGomUAbqCrHqzPrMk5
 S2+qbMV54Ub1CaOdwxpetLi/LjqtjwkZYEZdHrGYmgmUFR/F5fZH8/R8C+yxwZbdmYkJhaVU+
 31LyZe7EFF96pL7OWNPuuHrBFatTPYDJ8Xx5+Y8G9ZtnAtM3t1QaVHRIyAngv4YD8qnQTjXzz
 Oi+3MerIEiW6h022+LHMlsYHlpe2rZtBpbct3tkgUO+Gm1+R4k/z8zlIAvLb7VCikIv83b3kR
 uGWy9j1UBOlBHqQk++L8ud+JM3izkT4J5QodV0lcW6JkJPm8uVkSo+C80WOVXyvrLro4W/ogB
 WpjuBLu
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann