From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932455AbcFBJVo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 05:21:44 -0400
Received: from smtpout.microchip.com ([198.175.253.82]:40691 "EHLO
	email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S932164AbcFBJVl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 05:21:41 -0400
Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
To: Harvey Hunt <harvey.hunt@imgtec.com>, <linux-kernel@vger.kernel.org>
References: <1464844821-1581-1-git-send-email-purna.mandal@microchip.com>
 <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com>
CC: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
        Joshua Henderson <digitalpeer@digitalpeer.com>,
        Joshua Henderson <joshua.henderson@microchip.com>
From: Purna Chandra Mandal <purna.mandal@microchip.com>
Message-ID: <574FFA30.1000507@microchip.com>
Date: Thu, 2 Jun 2016 14:49:44 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/02/2016 02:45 PM, Harvey Hunt wrote:
> Hi Purna,
>
> On 02/06/16 06:20, Purna Chandra Mandal wrote:
>> Early clock API pic32_get_pbclk() is defined in early_clk.c and
>> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
>> set, early_clk.c isn't compiled and so a linker error is reported
>> while referring the API from time.c.
>
> Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
ack.

>>
>> Fix it by compiling early_clk.c always. Also sort files in
>> alphabetical order.
>>
>> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
>> Cc: Ralf Baechle <ralf@linux-mips.org>
>> Cc: linux-mips@linux-mips.org
>> Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
>>
>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>>
>> ---
>>
>>  arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
>> index 4a4c272..c286496 100644
>> --- a/arch/mips/pic32/pic32mzda/Makefile
>> +++ b/arch/mips/pic32/pic32mzda/Makefile
>> @@ -2,8 +2,7 @@
>>  # Joshua Henderson, <joshua.henderson@microchip.com>
>>  # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
>>  #
>> -obj-y            := init.o time.o config.o
>> +obj-y            := config.o early_clk.o init.o time.o
>>
>>  obj-$(CONFIG_EARLY_PRINTK)    += early_console.o      \
>> -                   early_pin.o        \
>> -                   early_clk.o
>> +                   early_pin.o
>>
>
> Perhaps add:
>
> Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
> Thanks for fixing this,
>
> Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
Thanks Harvey.

> Thanks,
>
> Harvey