From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932953AbcFBO5w (ORCPT ); Thu, 2 Jun 2016 10:57:52 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38080 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932916AbcFBO5u (ORCPT ); Thu, 2 Jun 2016 10:57:50 -0400 Subject: Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo To: Mark Brown References: <1464862996-3147-1-git-send-email-srinivas.kandagatla@linaro.org> <1464862996-3147-4-git-send-email-srinivas.kandagatla@linaro.org> <20160602144932.GK2282@sirena.org.uk> Cc: bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, Liam Girdwood , linux-arm-msm@vger.kernel.org From: Srinivas Kandagatla Message-ID: <57504966.6030800@linaro.org> Date: Thu, 2 Jun 2016 15:57:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160602144932.GK2282@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/16 15:49, Mark Brown wrote: > On Thu, Jun 02, 2016 at 11:23:16AM +0100, Srinivas Kandagatla wrote: >> This patch converts a fixed voltage pm8941 lnldo to a single step >> linear range regulator, so that we could use the same list_volatage >> callback without BUG_ON from regulator core. > > Why is this better than using a separate set of ops for the driver? Am ok either way, it would be just few more lines for separate set of ops. --srini