From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161151AbcFBPPg (ORCPT ); Thu, 2 Jun 2016 11:15:36 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35045 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932905AbcFBPPf (ORCPT ); Thu, 2 Jun 2016 11:15:35 -0400 Subject: Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions *** To: Arnd Bergmann , Binoy Jayan References: <1464841450-24772-1-git-send-email-binoy.jayan@linaro.org> <36502370.4CHTSZ0bH6@wuerfel> Cc: Greg Kroah-Hartman , Florian Schilhabel , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org From: Larry Finger Message-ID: <57504D94.6040808@lwfinger.net> Date: Thu, 2 Jun 2016 10:15:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <36502370.4CHTSZ0bH6@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2016 02:43 AM, Arnd Bergmann wrote: > On Thursday, June 2, 2016 9:54:06 AM CEST Binoy Jayan wrote: >> Hi, >> >> These are a set of patches [v2] which removes semaphores from: >> >> drivers/staging/rtl8712 >> >> They build correctly (individually and as a whole). >> NB: I have not tested this as I do not have the following hardware: >> >> "RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver" >> >> Rework on comments w.r.t. PATCH v1: >> >> - Removed wrapper functions _wait_completion, _down_sema and _enter_pwrlock >> - Updated changelog to explain use of mutex_lock instead of >> mutex_lock_interruptible in [PATCH v2 4/4] >> > > All four look great now, > > Reviewed-by: Arnd Bergmann I agree. Tested-by: Larry Finger Larry