From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161216AbcFBVoZ (ORCPT ); Thu, 2 Jun 2016 17:44:25 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34787 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161009AbcFBVoX (ORCPT ); Thu, 2 Jun 2016 17:44:23 -0400 Subject: Re: [PATCH] of: use pr_fmt prefix for all console printing To: Rob Herring References: <1464880499-29864-1-git-send-email-robh@kernel.org> <57506DDC.3060804@gmail.com> Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pantelis Antoniou From: Frank Rowand Message-ID: <5750A8B0.9010702@gmail.com> Date: Thu, 2 Jun 2016 14:44:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/16 12:56, Rob Herring wrote: > On Thu, Jun 2, 2016 at 12:33 PM, Frank Rowand wrote: >> On 06/02/16 08:14, Rob Herring wrote: >>> Clean-up all the DT printk functions to use common pr_fmt prefix. >>> >>> Some print statements such as kmalloc errors were redundant, so just >>> drop those. >>> >>> Cc: Frank Rowand >>> Cc: Pantelis Antoniou >>> Signed-off-by: Rob Herring >>> --- >>> drivers/of/address.c | 49 ++++++++++++++++++++++---------------------- >>> drivers/of/base.c | 11 ++++++---- >>> drivers/of/dynamic.c | 47 +++++++++++++++++++++--------------------- >>> drivers/of/fdt.c | 12 +++++------ >>> drivers/of/fdt_address.c | 35 ++++++++++++++++--------------- >>> drivers/of/irq.c | 2 ++ >>> drivers/of/of_numa.c | 22 ++++++-------------- >>> drivers/of/of_pci.c | 6 ++++-- >>> drivers/of/of_reserved_mem.c | 22 ++++++++++---------- >>> drivers/of/overlay.c | 43 +++++++++++++++----------------------- >>> drivers/of/platform.c | 16 +++++++-------- >>> drivers/of/resolver.c | 2 ++ >>> 12 files changed, 130 insertions(+), 137 deletions(-) >>> >> >> Nice cleanup. A couple of comments below. >> >> Reviewed-by: Frank Rowand >> >> < snip > < snip > >>> @@ -355,8 +355,6 @@ int of_overlay_create(struct device_node *tree) >>> >>> id = idr_alloc(&ov_idr, ov, 0, 0, GFP_KERNEL); >>> if (id < 0) { >>> - pr_err("%s: idr_alloc() failed for tree@%s\n", >>> - __func__, tree->full_name); >> >> Every other error in of_overlay_create() results in a pr_err(). >> (The other cases of removing pr_err() in this file are fine, because >> the errors are already reported in the functions called from this >> function.) >> >> I would recommend leaving in the pr_err() for idr_alloc() failure. > > I was thinking idr_alloc is going to call kmalloc which will print > errors on failure, but there may be some case it doesn't. > > Rob I did not read idr_alloc() carefully enough. Given the arguments it is called with, none of the non-kmalloc error returns are possible. So you were correct to remove this pr_err(). -Frank