public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Rocky Hsiao <rocky.hsiao@dyna-image.com>, linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Olof Johansson <olofj@chromium.org>,
	Filipe Brandenburger <filbranden@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Sonny Rao <sonnyrao@chromium.org>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Daniel Baluta <daniel.baluta@intel.com>,
	Adriana Reus <adriana.reus@intel.com>,
	Gwendal Grignou <gwendal@chromium.org>,
	Matt Ranostay <mranostay@gmail.com>,
	Puthikorn Voravootivat <puthik@chromium.org>,
	Andreas Dannenberg <dannenberg@ti.com>,
	linux-iio@vger.kernel.org, John Huang <john.huang@dyna-image.com>
Subject: Re: [PATCH] Dyna-Image AL3320A update, add AL3010 driver
Date: Fri, 3 Jun 2016 10:20:37 +0200	[thread overview]
Message-ID: <57513DD5.3060507@metafoo.de> (raw)
In-Reply-To: <1464926549-43040-1-git-send-email-rocky.hsiao@dyna-image.com>

On 06/03/2016 06:02 AM, Rocky Hsiao wrote:
> 1. Change al3320a.c to match light sensor test flow.
> 2. Add al3010.c to add new device AL3010.
>    original file copy from al3320a.c

Hi,

Thanks for the patch. In addition to what Daniel said, for upstream patch
submissions it is important to have proper commit messages explaining what
is done, why it is done and how it is done. The commit messages should
follow the general style of the subsystem you are sending the patch to. E.g.
in the IIO case this means that the subject line should start with "iio: ...".

http://chris.beams.io/posts/git-commit/ is a very good document that
describes how to create a good commit message and I recommend reading it.

- Lars

      parent reply	other threads:[~2016-06-03  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  4:02 [PATCH] Dyna-Image AL3320A update, add AL3010 driver Rocky Hsiao
2016-06-03  7:45 ` Daniel Baluta
2016-06-03  8:35   ` Jonathan Cameron
2016-06-03  8:40     ` Jonathan Cameron
2016-06-03  7:51 ` Benson Leung
2016-06-03  8:20 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57513DD5.3060507@metafoo.de \
    --to=lars@metafoo.de \
    --cc=adriana.reus@intel.com \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=daniel.baluta@intel.com \
    --cc=dannenberg@ti.com \
    --cc=dianders@chromium.org \
    --cc=djkurtz@chromium.org \
    --cc=filbranden@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=john.huang@dyna-image.com \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=olofj@chromium.org \
    --cc=pmeerw@pmeerw.net \
    --cc=puthik@chromium.org \
    --cc=rocky.hsiao@dyna-image.com \
    --cc=sonnyrao@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox