From: "Matias Bjørling" <m@bjorling.me>
To: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Keith Busch <keith.busch@intel.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian
Date: Fri, 3 Jun 2016 15:17:35 +0200 [thread overview]
Message-ID: <5751836F.7060407@bjorling.me> (raw)
In-Reply-To: <1464957858-59392-1-git-send-email-jthumshirn@suse.de>
On 06/03/2016 02:44 PM, Johannes Thumshirn wrote:
> According to the OpenChannel SSD interface specification the NAND flash
> MLC page pairing information's number of page page pairings field is the
> first two bytes in the MLC Page Pairing data structure. The hardware's
> data structure itself is little endian so annotate it as such, like the
> rest of lighnvm's data structures.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/nvme/host/lightnvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 9461dd6..ea36cbb 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -156,7 +156,7 @@ struct nvme_nvm_completion {
>
> #define NVME_NVM_LP_MLC_PAIRS 886
> struct nvme_nvm_lp_mlc {
> - __u16 num_pairs;
> + __le16 num_pairs;
> __u8 pairs[NVME_NVM_LP_MLC_PAIRS];
> };
>
>
Thanks Johannes. Applied for 4.8.
prev parent reply other threads:[~2016-06-03 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 12:44 [PATCH] nvme: lightnvme: make MLC num_pairs little endian Johannes Thumshirn
2016-06-03 13:17 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5751836F.7060407@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox