From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932784AbcFCQsH (ORCPT ); Fri, 3 Jun 2016 12:48:07 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55127 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932291AbcFCQsE (ORCPT ); Fri, 3 Jun 2016 12:48:04 -0400 Subject: Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock To: Ivan Khoronzhuk , , References: <1464907028-19622-1-git-send-email-ivan.khoronzhuk@linaro.org> CC: , From: Grygorii Strashko Message-ID: <5751B4BB.5060005@ti.com> Date: Fri, 3 Jun 2016 19:47:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1464907028-19622-1-git-send-email-ivan.khoronzhuk@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote: > There is no reason in this lock. At least for now. > > Signed-off-by: Ivan Khoronzhuk > --- > > Based on master > > drivers/net/ethernet/ti/cpsw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 9919cb3..8d1d373 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset) > } > > struct cpsw_priv { > - spinlock_t lock; > struct platform_device *pdev; > struct net_device *ndev; > struct napi_struct napi_rx; > @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev, > } > > priv_sl2 = netdev_priv(ndev); > - spin_lock_init(&priv_sl2->lock); > priv_sl2->data = *data; > priv_sl2->pdev = pdev; > priv_sl2->ndev = ndev; > @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, ndev); > priv = netdev_priv(ndev); > - spin_lock_init(&priv->lock); > priv->pdev = pdev; > priv->ndev = ndev; > priv->dev = &ndev->dev; > Reviewed-by: Grygorii Strashko -- regards, -grygorii