From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbcFDAt5 (ORCPT ); Fri, 3 Jun 2016 20:49:57 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33409 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcFDAty (ORCPT ); Fri, 3 Jun 2016 20:49:54 -0400 Subject: Re: [PATCH] b43: Remove unused phy_a code To: =?UTF-8?Q?Michael_B=c3=bcsch?= References: <1464989566-1393-1-git-send-email-linux@roeck-us.net> <20160603233519.4606b1ef@wiggum> Cc: Kalle Valo , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <575225B8.2040607@roeck-us.net> Date: Fri, 3 Jun 2016 17:50:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160603233519.4606b1ef@wiggum> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2016 02:35 PM, Michael Büsch wrote: > On Fri, 3 Jun 2016 14:32:46 -0700 > Guenter Roeck wrote: > >> gcc-6 reports the following error with -Werror=unused-const-variable. >> >> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: >> 'b43_phyops_a' defined but not used >> >> Turns out a lot of code in this file is unused, so let's remove it. > > > All a-phy code is usused. > So you can basically remove the whole file and any other A-PHY code. I love removing code. I'll resend with more code removed. Guenter