From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750875AbcFDFlI (ORCPT ); Sat, 4 Jun 2016 01:41:08 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:32186 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbcFDFlF (ORCPT ); Sat, 4 Jun 2016 01:41:05 -0400 Subject: Re: [PATCH v9 00/14] Add support for remote unwind To: Arnaldo Carvalho de Melo References: <1464924803-22214-1-git-send-email-hekuang@huawei.com> <20160603070629.GB23006@krava> <20160603194205.GB27920@kernel.org> <20160603210602.GA3095@kernel.org> <20160603210927.GB3095@kernel.org> CC: Jiri Olsa , , , , , , , , , , , , , , , , From: Hekuang Message-ID: <57526978.6070905@huawei.com> Date: Sat, 4 Jun 2016 13:39:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160603210927.GB3095@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.55.166] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0C0206.57526988.00D3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a5e22b8f8141bf2dfca5f2992198fa4e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/6/4 5:09, Arnaldo Carvalho de Melo 写道: > Em Fri, Jun 03, 2016 at 06:06:02PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Jun 03, 2016 at 04:42:05PM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Fri, Jun 03, 2016 at 09:06:29AM +0200, Jiri Olsa escreveu: >>>> On Fri, Jun 03, 2016 at 03:33:09AM +0000, He Kuang wrote: >>>>> v9: >>>>> - Change function unwind__register_ops() to static. >>>>> - Move up unwind__prepare_access() in thread__insert_map() and save >>>>> map_groups__remove() call. >>>>> - Enclose multiple line if/else into braces. >>>>> - Fix miss modified function declaration for unwind__prepare_access() >>>>> in patch 10. >>> >>>> for patchset: >>> >>>> Acked-by: Jiri Olsa >>> Thanks, applied, build testing. >> Build tested went ok, but then 'perf top' crashes: >> >> [root@jouet ~]# perf top >> perf: Segmentation fault >> -------- backtrace -------- >> perf[0x55591b] >> /lib64/libc.so.6(+0x34ab0)[0x7f38ad9c1ab0] >> perf(normalize_arch+0x27)[0x534797] >> perf(unwind__prepare_access+0xbb)[0x52b15b] >> perf(thread__insert_map+0x27)[0x4d4837] >> perf(machine__process_mmap2_event+0xd7)[0x4ca187] >> perf(perf_event__synthesize_mmap_events+0x3e2)[0x491b32] >> perf(perf_event__synthesize_threads+0x445)[0x492635] >> perf(cmd_top+0xee0)[0x442f50] >> perf[0x486a91] >> perf(main+0x6ee)[0x42485e] >> /lib64/libc.so.6(__libc_start_main+0xf0)[0x7f38ad9ad580] >> perf(_start+0x29)[0x424949] >> [0x0] >> [root@jouet ~]# >> >> And I bet that 'perf trace' will too, lemme see, well, it crashes even >> more spetacularly, but that is the topic of another bug report, will >> send soon. >> >> Anyway, please try your patchkit with 'perf top' and 'perf trace', as >> both don't use perf.data files, i.e. they work 'live', so probably >> things that you touch in normalize_arch() are not initialized and need >> to be setup. > Ah, no need to resend the whole patchkit, just find out what is the bug > and send me a patch and I'll insert it at the right point to avoid > introducing a bisect breaking point. > > Your patchkit is in my perf/unwind branch at my tree, I already added > Jiri's Acked-by in all the patches. > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > Thanks, > > - Arnaldo > - I send the updated one after PATCH 10/14, env->arch is null in live mode, comments are added and "perf top/trace" works now. Thanks.