From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038AbcFDUDQ (ORCPT ); Sat, 4 Jun 2016 16:03:16 -0400 Received: from mout.web.de ([212.227.15.14]:54053 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbcFDUDN (ORCPT ); Sat, 4 Jun 2016 16:03:13 -0400 Subject: Re: [PATCH] rtlwifi: Change long delays to sleeps To: Kalle Valo References: <1455574327-2591-1-git-send-email-Larry.Finger@lwfinger.net> <57530495.50302@web.de> <87fusssxqn.fsf@kamboji.qca.qualcomm.com> Cc: Larry Finger , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Linux Kernel Mailing List From: Jan Kiszka Message-ID: <575333EB.1060101@web.de> Date: Sat, 4 Jun 2016 22:02:51 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <87fusssxqn.fsf@kamboji.qca.qualcomm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WCFEgWEdhRMKoUtf3IA1a5bAtHd55m729" X-Provags-ID: V03:K0:TMATmATPgYEvStJg99di1m1rUHsBFbrS5GgsY9xymusguFBQ0HF 7cd3aPJ33ZT0miz35xmNpFq06kb9yNA8XMTMmbBUensKjbs59DZllLGFpPalXEtC9hZ+6GW NP+R2Glrt5iNH0ahdNY9AMxz4UQfyJFcqyCo0iR1aEAAeJF+kyaTfmvkJgtDeTBKanceLs1 esDZZGvRw9suRcGSoe+ew== X-UI-Out-Filterresults: notjunk:1;V01:K0:5O3HtVJfUQ4=:IJG/3JSxQfoRz5OVKK3kHi o24Q3sbnXTc9ayNUH7xH4FfAcChyNYZ5atk7EyxK4fPOXBkDx0NACXcO3/KZOtKLKB6BX/QIl 1D0TjamB0SGRAgZmDrXbZXu5mVLm0bLRCVWU4DBXY5nAAcEWQnlaYmILPKXiMcwaYSquCd33h CqpDyQ1+zoPLHH+lSAEcXz4RunI/hGhIOwYUW0JzC/VrDBF78BoocTtQindROPOwmMlniQ5EL qzV/SUuTbSop511oPqnAh/fegH5Pof2d/KIuVWQE7RLnkk54Xlr04RNz0ZjT/WC44wOi4LDnw xsdASZubFwUXsDsLYCJn0XzGTIgRHpxW2oMcYiK667uBfAWd1LjVCEXBwgM0XuBjjTxwfUsFh uSw4zoNxnzoz/+6kCiATDcjt/RJiB3tzDssjSaccE8T1mmcsEYBYhTvSX5IwkW2tZoio7ADq0 T+6JcXIQb1puNJOK3JBLrCDOfU6nrPIfHcwAVcbj6+Pz7M0cJOIu0eL5OB1ZkUfJD9Ffkxvru ZWoDck+eAK2eaPxq73JvvUAY7z1HcxBcfCMfi9awtmIbmlOds7kbeZTtv1bN/tj7QkEuVBypJ gFMRepXuDG1+cua8BpzbVw/l1wsUq8k4vLAGBU4yDzNl/aCxlTIbJHr0urJC9K5KXI0iDw1le jg+rRlsmMDlLSlARZQVuZjqCnKaeOaLG75beonLYHFMn+RedWEv1RMBU0al/Jsfnum5NQlEJ1 FO8Pi6qDZS23J7VfSH8PxaTiK2Og061q6QQVawTbBcHvX+cgc8IOaQhi3q4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WCFEgWEdhRMKoUtf3IA1a5bAtHd55m729 Content-Type: multipart/mixed; boundary="SJCbkLx6VuddDrprM5aWcrKxVsxLdncTu" From: Jan Kiszka To: Kalle Valo Cc: Larry Finger , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Linux Kernel Mailing List Message-ID: <575333EB.1060101@web.de> Subject: Re: [PATCH] rtlwifi: Change long delays to sleeps References: <1455574327-2591-1-git-send-email-Larry.Finger@lwfinger.net> <57530495.50302@web.de> <87fusssxqn.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87fusssxqn.fsf@kamboji.qca.qualcomm.com> --SJCbkLx6VuddDrprM5aWcrKxVsxLdncTu Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-06-04 18:52, Kalle Valo wrote: > Jan Kiszka writes: >=20 >> On 2016-02-15 23:12, Larry Finger wrote: >>> Routine rtl_addr_delay() uses delay statements in code that can >>> sleep. To improve system responsiveness, the various delay statements= >>> are changed. >>> >>> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are >>> rewritten to use the code in rtl_addr_delay() for most of their >>> input values. >>> >>> Suggested-by: Byeoungwook Kim >>> Signed-off-by: Larry Finger >=20 > [...] >=20 >> This breaks spectacularly when turning on a little bit of correctness >> checking: >> >> BUG: scheduling while atomic: wpa_supplicant/1116/0x00000002 >=20 > This should fix it: >=20 > https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers.git= /commit/?id=3Dde26859dcf363d520cc44e59f6dcaf20ebe0aadf >=20 Probably, will test later. But you should really work on making all these task-context-only. Threaded IRQs? Jan --SJCbkLx6VuddDrprM5aWcrKxVsxLdncTu-- --WCFEgWEdhRMKoUtf3IA1a5bAtHd55m729 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAldTM+sACgkQitSsb3rl5xS13gCghEWxFzlOLXs+fIf7EQRLGpVu 7VEAnAsYE+V9V8nziVl7hwi3ge7UZEpF =OAtT -----END PGP SIGNATURE----- --WCFEgWEdhRMKoUtf3IA1a5bAtHd55m729--