From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbcFEQb6 (ORCPT ); Sun, 5 Jun 2016 12:31:58 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35896 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbcFEQb4 (ORCPT ); Sun, 5 Jun 2016 12:31:56 -0400 Subject: Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion To: Binoy Jayan , Greg Kroah-Hartman References: <1464947943-2008-1-git-send-email-binoy.jayan@linaro.org> <1464947943-2008-2-git-send-email-binoy.jayan@linaro.org> Cc: Jakub Sitnicki , Arnd Bergmann , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org From: Larry Finger Message-ID: <575453FA.6090604@lwfinger.net> Date: Sun, 5 Jun 2016 11:31:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1464947943-2008-2-git-send-email-binoy.jayan@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2016 04:59 AM, Binoy Jayan wrote: > The semaphore 'cmd_queue_sema' is used as completion, > so convert it to struct completion. > > Signed-off-by: Binoy Jayan The subject for this patch has a misplaced "i" at the beginning courtesy of vi. One other point, it is customary to start the patch subject with "staging: rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than rtl8188eu as the former is the actual name of the driver, but either will work. I have tested all 4 of these patches with no problems, thus Acked-by: Larry Finger As you may have noted, my testing of the modified driver has resulted in some additional fixes for various problems including a system panic caused by an ill-advised and untested change. Larry