From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751774AbcFFGw2 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 02:52:28 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:8957 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751118AbcFFGw0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 02:52:26 -0400
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Sun, 05 Jun 2016 23:49:22 -0700
Message-ID: <57551AAD.2020805@nvidia.com>
Date: Mon, 6 Jun 2016 12:09:41 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Rhyland Klein <rklein@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC: Stephen Warren <swarren@wwwdotorg.org>, Jon Hunter <jonathanh@nvidia.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Andrew Bresticker <abrestic@chromium.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug
References: <1464985365-11612-1-git-send-email-rklein@nvidia.com>
In-Reply-To: <1464985365-11612-1-git-send-email-rklein@nvidia.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com
 (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote:
> +
> +			max77620_default: pinmux@0 {
> +				pin_gpio {
> +					pins = "gpio0", "gpio1", "gpio2", "gpio5",
> +					       "gpio6", "gpio7";
gpio5 and gpio6 are already there in below nodes and hence it is not 
needed here.

> +					function = "gpio";
> +				};
> +
> +				/*
> +				 * GPIO3 is used to en_pp3300, and it is part of power
> +				 * sequence, So it must be sequenced up (automatically
> +				 * set by OTP) and down properly.
> +				 */
> +				pin_gpio3 {
> +					pins = "gpio3";
> +					function = "fps-out";
> +					drive-open-drain = <1>;
> +					maxim,active-fps-source = <MAX77620_FPS_SRC_0>;
> +					maxim,active-fps-power-up-slot = <4>;
> +					maxim,active-fps-power-down-slot = <2>;
> +				};
> +
> +				pin_gpio5_6_7 {
node name should be gpio5_6 as there is no gpio7 inside this node.


> +
> +			regulators {
> +				in-ldo0-1-supply = <&pp1350>;
> +				in-ldo2-supply = <&pp3300>;
> +				in-ldo3-5-supply = <&pp3300>;
> +				in-ldo7-8-supply = <&pp1350>;
> +
> +				ppvar_soc: sd0 {
> +					regulator-name = "PPVAR_SOC";
> +					regulator-min-microvolt = <825000>;
> +					regulator-max-microvolt = <1125000>;
> +					regulator-enable-ramp-delay = <146>;
> +					regulator-disable-ramp-delay = <4080>;
> +					regulator-ramp-delay = <27500>;
> +					regulator-ramp-delay-scale = <300>;

There is no disable-ramp-delay in mainline.
Please use the correct value for property as:
                                      regulator-ramp-delay = <9000>;
                                      maxim,ramp-rate-setting = <27500>;


instead of regulator-ramp-delay and regulator-ramp-delay-scale.
The property differs from downstream.

regulator-ramp-delay is what you see in platform and 
maxim,ramp-rate-setting is what you want in register.