Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device

Greg Kroah-Hartman
2016-06-08T04:45:20Z

On Thu, Jun 02, 2016 at 09:37:28AM +0800, Lu Baolu wrote:
> In some Intel platforms, a single usb port is shared between USB host
> and device controllers. The shared port is under control of a switch
> which is defined in the Intel vendor defined extended capability for
> xHCI.
>
> This patch adds the support to detect and create the platform device
> for the port mux switch.

Why do you need a platform device for this? You do nothing with this
device, why create it at all?

And why is it a platform device, isn't is really a PCI device? Why
would you ever find a "platform" device below a PCI device? Don't abuse
platform devices for things that aren't. It makes me want to delete
that whole interface more and more...

greg k-h