From: "Matias Bjørling" <m@bjorling.me>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] lightnvm: Make functions not used by ouside static
Date: Mon, 6 Jun 2016 09:07:50 +0200 [thread overview]
Message-ID: <57552146.4010300@bjorling.me> (raw)
In-Reply-To: <1464963006-22721-1-git-send-email-jthumshirn@suse.de>
On 06/03/2016 04:10 PM, Johannes Thumshirn wrote:
> Mark functions not used by ouside of thier implementing file as static.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/lightnvm/core.c | 2 +-
> drivers/lightnvm/sysblk.c | 8 +++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 0dc9a80..19577df 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -98,7 +98,7 @@ static struct nvmm_type *nvm_find_mgr_type(const char *name)
> return NULL;
> }
>
> -struct nvmm_type *nvm_init_mgr(struct nvm_dev *dev)
> +static struct nvmm_type *nvm_init_mgr(struct nvm_dev *dev)
> {
> struct nvmm_type *mt;
> int ret;
> diff --git a/drivers/lightnvm/sysblk.c b/drivers/lightnvm/sysblk.c
> index b1e1404..ba2afe9 100644
> --- a/drivers/lightnvm/sysblk.c
> +++ b/drivers/lightnvm/sysblk.c
> @@ -39,7 +39,8 @@ static inline int scan_ppa_idx(int row, int blkid)
> return (row * MAX_BLKS_PR_SYSBLK) + blkid;
> }
>
> -void nvm_sysblk_to_cpu(struct nvm_sb_info *info, struct nvm_system_block *sb)
> +static void nvm_sysblk_to_cpu(struct nvm_sb_info *info,
> + struct nvm_system_block *sb)
> {
> info->seqnr = be32_to_cpu(sb->seqnr);
> info->erase_cnt = be32_to_cpu(sb->erase_cnt);
> @@ -48,7 +49,8 @@ void nvm_sysblk_to_cpu(struct nvm_sb_info *info, struct nvm_system_block *sb)
> info->fs_ppa.ppa = be64_to_cpu(sb->fs_ppa);
> }
>
> -void nvm_cpu_to_sysblk(struct nvm_system_block *sb, struct nvm_sb_info *info)
> +static void nvm_cpu_to_sysblk(struct nvm_system_block *sb,
> + struct nvm_sb_info *info)
> {
> sb->magic = cpu_to_be32(NVM_SYSBLK_MAGIC);
> sb->seqnr = cpu_to_be32(info->seqnr);
> @@ -86,7 +88,7 @@ static int nvm_setup_sysblks(struct nvm_dev *dev, struct ppa_addr *sysblk_ppas)
> return nr_rows;
> }
>
> -void nvm_setup_sysblk_scan(struct nvm_dev *dev, struct sysblk_scan *s,
> +static void nvm_setup_sysblk_scan(struct nvm_dev *dev, struct sysblk_scan *s,
> struct ppa_addr *sysblk_ppas)
> {
> memset(s, 0, sizeof(struct sysblk_scan));
>
Thanks Johannes. Applied for 4.8.
prev parent reply other threads:[~2016-06-06 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 14:10 [PATCH] lightnvm: Make functions not used by ouside static Johannes Thumshirn
2016-06-06 7:07 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57552146.4010300@bjorling.me \
--to=m@bjorling.me \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox